Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL] Improve error messages #4558

Closed
wants to merge 9 commits into from
Closed

Conversation

@marmbrus
Copy link
Contributor

marmbrus commented Feb 12, 2015

No description provided.

@SparkQA

This comment has been minimized.

Copy link

SparkQA commented Feb 12, 2015

Test build #27333 has started for PR 4558 at commit 34eb3a4.

  • This patch merges cleanly.
@SparkQA

This comment has been minimized.

Copy link

SparkQA commented Feb 12, 2015

Test build #27334 has started for PR 4558 at commit af9e668.

  • This patch merges cleanly.
@SparkQA

This comment has been minimized.

Copy link

SparkQA commented Feb 12, 2015

Test build #27336 has started for PR 4558 at commit d4e9015.

  • This patch merges cleanly.
@rxin

This comment has been minimized.

Copy link
Contributor

rxin commented Feb 12, 2015

This is going to be huge. You probably want a JIRA ticket for this.

@SparkQA

This comment has been minimized.

Copy link

SparkQA commented Feb 12, 2015

Test build #27338 has started for PR 4558 at commit d29fbde.

  • This patch merges cleanly.
@SparkQA

This comment has been minimized.

Copy link

SparkQA commented Feb 12, 2015

Test build #27333 has finished for PR 4558 at commit 34eb3a4.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@AmplabJenkins

This comment has been minimized.

Copy link

AmplabJenkins commented Feb 12, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27333/
Test FAILed.

@SparkQA

This comment has been minimized.

Copy link

SparkQA commented Feb 12, 2015

Test build #27334 has finished for PR 4558 at commit af9e668.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • trait DataFrame extends RDDApi[Row] with Serializable
@AmplabJenkins

This comment has been minimized.

Copy link

AmplabJenkins commented Feb 12, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27334/
Test FAILed.

@SparkQA

This comment has been minimized.

Copy link

SparkQA commented Feb 12, 2015

Test build #27336 has finished for PR 4558 at commit d4e9015.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@AmplabJenkins

This comment has been minimized.

Copy link

AmplabJenkins commented Feb 12, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27336/
Test FAILed.

@SparkQA

This comment has been minimized.

Copy link

SparkQA commented Feb 12, 2015

Test build #27338 has finished for PR 4558 at commit d29fbde.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@AmplabJenkins

This comment has been minimized.

Copy link

AmplabJenkins commented Feb 12, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27338/
Test FAILed.

// of the result of cascading resolution failures.
plan.foreachUp {
case operator: LogicalPlan =>
operator transformAllExpressions {

This comment has been minimized.

Copy link
@scwf

scwf Feb 12, 2015

Contributor

we can use transformExpressionsUp here to cover the case of SELECT CAST(x AS STRING) FROM src

@scwf

This comment has been minimized.

Copy link
Contributor

scwf commented Feb 12, 2015

@marmbrus, i filed a Pr for your branch(marmbrus#15), hopefully it is useful

fix for `Improve error messages`
@marmbrus

This comment has been minimized.

Copy link
Contributor Author

marmbrus commented Feb 12, 2015

Thanks for the PR!

@SparkQA

This comment has been minimized.

Copy link

SparkQA commented Feb 12, 2015

Test build #27364 has started for PR 4558 at commit 5e5ab50.

  • This patch merges cleanly.
@SparkQA

This comment has been minimized.

Copy link

SparkQA commented Feb 12, 2015

Test build #27364 has finished for PR 4558 at commit 5e5ab50.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@AmplabJenkins

This comment has been minimized.

Copy link

AmplabJenkins commented Feb 12, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27364/
Test PASSed.

@asfgit asfgit closed this in aa4ca8b Feb 12, 2015
asfgit pushed a commit that referenced this pull request Feb 12, 2015
Author: Michael Armbrust <michael@databricks.com>
Author: wangfei <wangfei1@huawei.com>

Closes #4558 from marmbrus/errorMessages and squashes the following commits:

5e5ab50 [Michael Armbrust] Merge pull request #15 from scwf/errorMessages
fa38881 [wangfei] fix for grouping__id
f279a71 [wangfei] make right references for ScriptTransformation
d29fbde [Michael Armbrust] extra case
1a797b4 [Michael Armbrust] comments
d4e9015 [Michael Armbrust] add comment
af9e668 [Michael Armbrust] no braces
34eb3a4 [Michael Armbrust] more work
6197cd5 [Michael Armbrust] [SQL] Better error messages for analysis failures

(cherry picked from commit aa4ca8b)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@marmbrus marmbrus deleted the marmbrus:errorMessages branch Feb 17, 2015
preaudc pushed a commit to preaudc/spark that referenced this pull request Apr 17, 2015
Author: Michael Armbrust <michael@databricks.com>
Author: wangfei <wangfei1@huawei.com>

Closes apache#4558 from marmbrus/errorMessages and squashes the following commits:

5e5ab50 [Michael Armbrust] Merge pull request apache#15 from scwf/errorMessages
fa38881 [wangfei] fix for grouping__id
f279a71 [wangfei] make right references for ScriptTransformation
d29fbde [Michael Armbrust] extra case
1a797b4 [Michael Armbrust] comments
d4e9015 [Michael Armbrust] add comment
af9e668 [Michael Armbrust] no braces
34eb3a4 [Michael Armbrust] more work
6197cd5 [Michael Armbrust] [SQL] Better error messages for analysis failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.