[SPARK-47456][SQL] Support ORC Brotli codec #45584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaooqinn
approved these changes
Mar 19, 2024
LuciferYang
reviewed
Mar 19, 2024
| @@ -71,6 +71,9 @@ class OrcCodecSuite extends FileSourceCodecSuite { | |||
|
|
|||
| override def format: String = "orc" | |||
| override val codecConfigName: String = SQLConf.ORC_COMPRESSION.key | |||
| // Exclude "BROTLI" because its dependencies | |||
| // require adding different jars according to different OSs | |||
There was a problem hiding this comment.
Which jar should be used when the user wants to enable this feature?
There was a problem hiding this comment.
This one. I excluded intentionally during upgrading to Apache ORC 2.0.0.
Lines 2615 to 2618 in 681b41f
There was a problem hiding this comment.
As he mentioned, native brotli should be available in the system, too.
There was a problem hiding this comment.
Thanks for the comment, I've added the dependencies that need to be added to the PR description.
dongjoon-hyun
approved these changes
Mar 19, 2024
docs/sql-data-sources-orc.md
Outdated
| @@ -241,7 +241,7 @@ Data source options of ORC can be set via: | |||
| <tr> | |||
| <td><code>compression</code></td> | |||
| <td><code>zstd</code></td> | |||
| <td>compression codec to use when saving to file. This can be one of the known case-insensitive shorten names (none, snappy, zlib, lzo, zstd and lz4). This will override <code>orc.compress</code> and <code>spark.sql.orc.compression.codec</code>.</td> | |||
| <td>compression codec to use when saving to file. This can be one of the known case-insensitive shorten names (none, snappy, zlib, lzo, zstd, lz4 and brotli). This will override <code>orc.compress</code> and <code>spark.sql.orc.compression.codec</code>.</td> | |||
There was a problem hiding this comment.
Like Parquet, we need a Note here, @cxzl25 .
spark/docs/sql-data-sources-parquet.md
Line 488 in 5f48931
LuciferYang
approved these changes
Mar 19, 2024
dongjoon-hyun
approved these changes
Mar 19, 2024
|
Merged to master for Apache Spark 4.0.0. Thank you, @cxzl25 , @yaooqinn , @LuciferYang ! |
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
### What changes were proposed in this pull request? This PR aims to support ORC Brotli codec. ### Why are the changes needed? Currently, the master branch of Spark has used ORC 2.0.0 version and supports brotli compression encoding. ([SPARK-44115](https://issues.apache.org/jira/browse/SPARK-44115)) However, due to some hardcode checks in Spark, brotli cannot be used normally. ```sql set spark.sql.orc.compression.codec=BROTLI; ``` ``` java.lang.IllegalArgumentException: The value of spark.sql.orc.compression.codec should be one of uncompressed, lz4, lzo, snappy, zlib, none, zstd, but was brotli ``` See apache/orc#1714 ### Does this PR introduce _any_ user-facing change? Yes In this PR, add the corresponding brotli jar package, we can use orc brotli encoding. ```xml <dependency> <groupId>com.aayushatharva.brotli4j</groupId> <artifactId>brotli4j</artifactId> </dependency> ``` REF: https://github.com/netty/netty/blob/3cd364107167600e8eb4b0b85553ed895519e2ed/codec/pom.xml#L91-L125 ### How was this patch tested? local test <img width="850" alt="image" src="https://github.com/apache/spark/assets/3898450/4e4f9422-1cf2-45ef-8bcc-8bae6188beb7"> ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#45584 from cxzl25/orc_brotli_codec. Authored-by: sychen <sychen@ctrip.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to support ORC Brotli codec.
Why are the changes needed?
Currently, the master branch of Spark has used ORC 2.0.0 version and supports brotli compression encoding. (SPARK-44115)
However, due to some hardcode checks in Spark, brotli cannot be used normally.
See apache/orc#1714
Does this PR introduce any user-facing change?
Yes
In this PR, add the corresponding brotli jar package, we can use orc brotli encoding.
REF: https://github.com/netty/netty/blob/3cd364107167600e8eb4b0b85553ed895519e2ed/codec/pom.xml#L91-L125
How was this patch tested?
local test
Was this patch authored or co-authored using generative AI tooling?
No