[SPARK-47544][PYTHON] SparkSession builder method is incompatible with visual studio code intellisense #45700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nija-at
changed the title
HyukjinKwon
changed the title
HyukjinKwon
approved these changes
Mar 26, 2024
|
Let's fix up the linter though: |
dongjoon-hyun
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
+1, LGTM. Thank you, @nija-at and @HyukjinKwon
Merged to master for Apache Spark 4.0.0.
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
…h visual studio code intellisense ### What changes were proposed in this pull request? VS Code's intellisense is unable to detect the methods and properties of `SparkSession.builder`. A video is worth a thousand words: [video](https://github.com/apache/spark/assets/16217941/e611e7e7-8760-4d9f-aa6c-9d4bd519d516). Adjust the implementation for better compatibility with the IDE. ### Why are the changes needed? Compatibility with IDE tooling. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Built the wheel file locally and tested on local IDE. See [video](https://github.com/apache/spark/assets/16217941/429b06dd-44a7-4d13-a551-c2b72c326c1e). Confirmed the same works for Pycharm. Further confirmed that the Pydocs for these methods are unaffected. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45700 from nija-at/vscode-intellisense. Authored-by: Niranjan Jayakar <nija@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
VS Code's intellisense is unable to detect the methods and properties of
SparkSession.builder. A video is worth a thousand words:video.
Adjust the implementation for better compatibility with the IDE.
Why are the changes needed?
Compatibility with IDE tooling.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Built the wheel file locally and tested on local IDE.
See video.
Confirmed the same works for Pycharm.
Further confirmed that the Pydocs for these methods are unaffected.
Was this patch authored or co-authored using generative AI tooling?
No.