[SPARK-47846][SQL] Add support for Variant type in from_json expression #46046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshmotw-db
changed the title
HyukjinKwon
reviewed
Apr 15, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
Outdated
Show resolved
Hide resolved
…hema is variant type
…essions/jsonExpressions.scala Co-authored-by: Hyukjin Kwon <gurwls223@gmail.com>
…park into from_json_variant
|
@chenhao-db can you please look at this whenever you're free? |
…park into from_json_variant
cloud-fan
approved these changes
Apr 18, 2024
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added support for the Variant type in the
from_jsonexpression. SQL statements likeselect from_json('{"a": 1, "b": 0.8}', 'variant')should convert the input json string to the variant type.Why are the changes needed?
Earlier,
from_jsononly supported fixed schemas in the schema field. Adding the variant data type should allow support for semi-structured data.Does this PR introduce any user-facing change?
Yes, users can now specify
'variant'as the schema infrom_jsonHow was this patch tested?
Unit tests.
from_json/to_jsonround trip tests are identical toparse_json/to_jsontests.Was this patch authored or co-authored using generative AI tooling?
No