[SPARK-48149][INFRA][FOLLOWUP] Use single quotation mark #46454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
commented
May 8, 2024
| - pyversion: ${{ github.event.schedule == '0 19 * * *' && "python3.12" }} | ||
| - pyversion: ${{ github.event.schedule == '0 15 * * *' && 'pypy3' }} | ||
| - pyversion: ${{ github.event.schedule == '0 17 * * *' && 'python3.10' }} | ||
| - pyversion: ${{ github.event.schedule == '0 19 * * *' && 'python3.12' }} |
There was a problem hiding this comment.
Single quotation mark will work like the following.
spark/.github/workflows/build_and_test.yml
Line 202 in 84c5b91
|
Could you review this fix, @HyukjinKwon ? |
HyukjinKwon
approved these changes
May 8, 2024
|
Merged to master. |
|
Thank you! |
dongjoon-hyun
added a commit
that referenced
this pull request
May 8, 2024
### What changes were proposed in this pull request? This PR aims to split `build_python.yml` into per-version cron jobs. Technically, this includes a revert of SPARK-48149 and choose [the discussed alternative](#46407 (comment)). - #46407 - #46454 ### Why are the changes needed? To recover Python CI successfully in ASF INFRA policy. - https://github.com/apache/spark/actions/workflows/build_python.yml ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46477 from dongjoon-hyun/SPARK-48200. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
### What changes were proposed in this pull request? This is a follow-up of - apache#46407 ### Why are the changes needed? To fix the invalid syntax error - https://github.com/apache/spark/actions/runs/8989374763 > The workflow is not valid. .github/workflows/build_python.yml (Line: 37, Col: 24): Unexpected symbol: '"pypy3"'. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46454 from dongjoon-hyun/SPARK-48149-2. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
### What changes were proposed in this pull request? This PR aims to split `build_python.yml` into per-version cron jobs. Technically, this includes a revert of SPARK-48149 and choose [the discussed alternative](apache#46407 (comment)). - apache#46407 - apache#46454 ### Why are the changes needed? To recover Python CI successfully in ASF INFRA policy. - https://github.com/apache/spark/actions/workflows/build_python.yml ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46477 from dongjoon-hyun/SPARK-48200. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of
build_python.ymlto run a single Python version per cron schedule #46407Why are the changes needed?
To fix the invalid syntax error
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual review.
Was this patch authored or co-authored using generative AI tooling?
No.