Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST Only] test sbt 1.10.0 performance without local maven repo cache #46532

Closed
wants to merge 3 commits into from

Conversation

panbingkun
Copy link
Contributor

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

@panbingkun
Copy link
Contributor Author

cc @LuciferYang @dongjoon-hyun

@panbingkun
Copy link
Contributor Author

I have narrowed the scope of the impact of not using local maven repo cache to the step MIMA test of the job lint

@LuciferYang
Copy link
Contributor

LuciferYang commented May 13, 2024

MIMA took 8 minutes and 6 seconds, and there doesn't seem to be a significant performance difference. I think this is feasible.

Could you have it run a few more times to confirm that this execution time is relatively stable? @panbingkun

@panbingkun
Copy link
Contributor Author

MIMA took 8 minutes and 6 seconds, and there doesn't seem to be a significant performance difference. I think this is feasible.

Could you have it run a few more times to confirm that this execution time is relatively stable? @panbingkun

Sure, let me to do it.

@panbingkun
Copy link
Contributor Author

I ran it twice again today.
It was verified that the performance of the mima step seemed to be stable at about 8 min and ... seconds without local maven repo cache.
@dongjoon-hyun @LuciferYang

@LuciferYang
Copy link
Contributor

This is fine for me, and the time is about the same as using the maven local cache. But I suggest splitting disable maven local cache and upgrade to sbt 1.10.0 into two separate PRs.

@panbingkun
Copy link
Contributor Author

This is fine for me, and the time is about the same as using the maven local cache. But I suggest splitting disable maven local cache and upgrade to sbt 1.10.0 into two separate PRs.

1.Disable maven local cache on GA's step MIMA test
#46551

After the above pr is merged, I will upgrade the sbt to 1.10.0 based on this pr.

@panbingkun
Copy link
Contributor Author

A test without local maven repo cache
#46606

Copy link

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Aug 25, 2024
@github-actions github-actions bot closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants