[SPARK-46957][CORE][FOLLOW-UP] Use Collections.emptyMap for Java compatibility #47121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix will be cherry-picked along with the backport PR #47122. This PR itself is for master only. |
|
@yaooqinn @LuciferYang Could you take a look? Thanks! |
|
@yaooqinn @LuciferYang Thanks for taking care of the backport PR. What do you think about merging this PR to master for code consistency? |
yaooqinn
approved these changes
Jun 28, 2024
|
Merged to master, thank you @Ngone51 |
asl3
pushed a commit
to asl3/spark
that referenced
this pull request
Jul 1, 2024
…atibility ### What changes were proposed in this pull request? This PR replaces `Map.of()` with `Collections.emptyMap()`. ### Why are the changes needed? To fix the Java compilation error for branch-3.5/3.4. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Covered by existing tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47121 from Ngone51/SPARK-46957-followup. Authored-by: Yi Wu <yi.wu@databricks.com> Signed-off-by: Kent Yao <yao@apache.org>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…atibility ### What changes were proposed in this pull request? This PR replaces `Map.of()` with `Collections.emptyMap()`. ### Why are the changes needed? To fix the Java compilation error for branch-3.5/3.4. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Covered by existing tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47121 from Ngone51/SPARK-46957-followup. Authored-by: Yi Wu <yi.wu@databricks.com> Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR replaces
Map.of()withCollections.emptyMap().Why are the changes needed?
To fix the Java compilation error for branch-3.5/3.4.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Covered by existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.