[SPARK-48804][SQL] Add classIsLoadable & OutputCommitter.isAssignableFrom check for output committer class configrations #47209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…From check for output committer class configrations
…From check for output committer class configrations
…From check for output committer class configrations
…From check for output committer class configrations
…From check for output committer class configrations
common/utils/src/main/scala/org/apache/spark/util/SparkClassUtils.scala
Outdated
Show resolved
Hide resolved
|
Thank you @dongjoon-hyun |
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Jul 10, 2024
…From check for output committer class configrations ### What changes were proposed in this pull request? This pull request proposed adding a checker for class values provided by users in `spark.sql.sources.outputCommitterClass` and `spark.sql.parquet.output.committer.class` to make sure the given class is visible from the classpath and a subclass of `org.apache.hadoop.mapreduce.OutputCommitter` ### Why are the changes needed? Ensure that an invalid configuration results in immediate application or query failure rather than failing late during setupJob. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? new tests ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#47209 from yaooqinn/SPARK-48804. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Kent Yao <yao@apache.org>
jingz-db
pushed a commit
to jingz-db/spark
that referenced
this pull request
Jul 22, 2024
…From check for output committer class configrations ### What changes were proposed in this pull request? This pull request proposed adding a checker for class values provided by users in `spark.sql.sources.outputCommitterClass` and `spark.sql.parquet.output.committer.class` to make sure the given class is visible from the classpath and a subclass of `org.apache.hadoop.mapreduce.OutputCommitter` ### Why are the changes needed? Ensure that an invalid configuration results in immediate application or query failure rather than failing late during setupJob. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? new tests ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#47209 from yaooqinn/SPARK-48804. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Kent Yao <yao@apache.org>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…From check for output committer class configrations ### What changes were proposed in this pull request? This pull request proposed adding a checker for class values provided by users in `spark.sql.sources.outputCommitterClass` and `spark.sql.parquet.output.committer.class` to make sure the given class is visible from the classpath and a subclass of `org.apache.hadoop.mapreduce.OutputCommitter` ### Why are the changes needed? Ensure that an invalid configuration results in immediate application or query failure rather than failing late during setupJob. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? new tests ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#47209 from yaooqinn/SPARK-48804. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pull request proposed adding a checker for class values provided by users in
spark.sql.sources.outputCommitterClassandspark.sql.parquet.output.committer.classto make sure the given class is visible from the classpath and a subclass oforg.apache.hadoop.mapreduce.OutputCommitterWhy are the changes needed?
Ensure that an invalid configuration results in immediate application or query failure rather than failing late during setupJob.
Does this PR introduce any user-facing change?
no
How was this patch tested?
new tests
Was this patch authored or co-authored using generative AI tooling?
no