[MINOR][DOCS] Fix some typos in docs #47261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panbingkun
commented
Jul 9, 2024
| @@ -9,9 +9,9 @@ To build | |||
|
|
|||
| ## Executor Code Profiling | |||
|
|
|||
| The spark profiler module enables code profiling of executors in cluster mode based on the the [async profiler](https://github.com/async-profiler/async-profiler/blob/v2.10/README.md), a low overhead sampling profiler. This allows a Spark application to capture CPU and memory profiles for application running on a cluster which can later be analyzed for performance issues. The profiler captures [Java Flight Recorder (jfr)](https://access.redhat.com/documentation/es-es/red_hat_build_of_openjdk/17/html/using_jdk_flight_recorder_with_red_hat_build_of_openjdk/openjdk-flight-recorded-overview) files for each executor; these can be read by many tools including Java Mission Control and Intellij. | |||
| The spark profiler module enables code profiling of executors in cluster mode based on the [async profiler](https://github.com/async-profiler/async-profiler/blob/v3.0/README.md), a low overhead sampling profiler. This allows a Spark application to capture CPU and memory profiles for application running on a cluster which can later be analyzed for performance issues. The profiler captures [Java Flight Recorder (jfr)](https://access.redhat.com/documentation/es-es/red_hat_build_of_openjdk/17/html/using_jdk_flight_recorder_with_red_hat_build_of_openjdk/openjdk-flight-recorded-overview) files for each executor; these can be read by many tools including Java Mission Control and Intellij. | |||
There was a problem hiding this comment.
After #45351, The version of ap-loader has been upgraded to the 3.x, we should update it synchronously.
HyukjinKwon
approved these changes
Jul 9, 2024
|
Merged to master. |
cloud-fan
reviewed
Jul 9, 2024
| @@ -59,31 +59,31 @@ except_clause | |||
|
|
|||
| ```sql | |||
| -- Return all columns in the FROM clause | |||
| SELECT * FROM VALUES(1, 2) AS TA(c1, c2), VALUES(‘a’, b’) AS TB(ca, cb); | |||
There was a problem hiding this comment.
interesting, did the test pass before?
There was a problem hiding this comment.
Hmm..., I think some docs under docs\... are not tested.
There was a problem hiding this comment.
oh sorry I misread it, it's doc only not a test
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Jul 10, 2024
### What changes were proposed in this pull request? The pr aims to fix some typos in some docs, includes: `docs/sql-ref-syntax-qry-star.md`, `docs/running-on-kubernetes.md` and `connector/profiler/README.md`. ### Why are the changes needed? https://spark.apache.org/docs/4.0.0-preview1/sql-ref-syntax-qry-star.html In some `sql examples` in the doc `docs/sql-ref-syntax-qry-star.md`, `Unicode Character 'SINGLE QUOTATION MARK'` was used, which resulted in the end-user being unable to execute successfully after `copy-paste`, eg: <img width="660" alt="image" src="https://github.com/apache/spark/assets/15246973/055aa0a8-602e-4ea7-a065-c8e0353c6fb3"> ### Does this PR introduce _any_ user-facing change? Yes, the end-users will face more user-friendly docs. ### How was this patch tested? Manually test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47261 from panbingkun/fix_typo_docs. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
jingz-db
pushed a commit
to jingz-db/spark
that referenced
this pull request
Jul 22, 2024
### What changes were proposed in this pull request? The pr aims to fix some typos in some docs, includes: `docs/sql-ref-syntax-qry-star.md`, `docs/running-on-kubernetes.md` and `connector/profiler/README.md`. ### Why are the changes needed? https://spark.apache.org/docs/4.0.0-preview1/sql-ref-syntax-qry-star.html In some `sql examples` in the doc `docs/sql-ref-syntax-qry-star.md`, `Unicode Character 'SINGLE QUOTATION MARK'` was used, which resulted in the end-user being unable to execute successfully after `copy-paste`, eg: <img width="660" alt="image" src="https://github.com/apache/spark/assets/15246973/055aa0a8-602e-4ea7-a065-c8e0353c6fb3"> ### Does this PR introduce _any_ user-facing change? Yes, the end-users will face more user-friendly docs. ### How was this patch tested? Manually test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47261 from panbingkun/fix_typo_docs. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? The pr aims to fix some typos in some docs, includes: `docs/sql-ref-syntax-qry-star.md`, `docs/running-on-kubernetes.md` and `connector/profiler/README.md`. ### Why are the changes needed? https://spark.apache.org/docs/4.0.0-preview1/sql-ref-syntax-qry-star.html In some `sql examples` in the doc `docs/sql-ref-syntax-qry-star.md`, `Unicode Character 'SINGLE QUOTATION MARK'` was used, which resulted in the end-user being unable to execute successfully after `copy-paste`, eg: <img width="660" alt="image" src="https://github.com/apache/spark/assets/15246973/055aa0a8-602e-4ea7-a065-c8e0353c6fb3"> ### Does this PR introduce _any_ user-facing change? Yes, the end-users will face more user-friendly docs. ### How was this patch tested? Manually test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47261 from panbingkun/fix_typo_docs. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to fix some typos in some docs, includes:
docs/sql-ref-syntax-qry-star.md,docs/running-on-kubernetes.mdandconnector/profiler/README.md.Why are the changes needed?
https://spark.apache.org/docs/4.0.0-preview1/sql-ref-syntax-qry-star.html
In some
sql examplesin the docdocs/sql-ref-syntax-qry-star.md,Unicode Character 'SINGLE QUOTATION MARK'was used, which resulted in the end-user being unable to execute successfully aftercopy-paste, eg:Does this PR introduce any user-facing change?
Yes, the end-users will face more user-friendly docs.
How was this patch tested?
Manually test.
Was this patch authored or co-authored using generative AI tooling?
No.