[SPARK-49005][K8S][3.4] Use 17-jammy tag instead of 17-jre to prevent Python 3.12
#47489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
17-jammy tag instead of 17 to prevent Python 3.1217-jammy tag instead of 17-jre to prevent Python 3.12
|
Also, cc @huaxingao |
huaxingao
approved these changes
Jul 25, 2024
|
Thank you, @huaxingao ! |
|
Let me merge this to recover the CIs. |
dongjoon-hyun
added a commit
that referenced
this pull request
Jul 25, 2024
…vent Python 3.12 ### What changes were proposed in this pull request? This PR aims to use `17-jammy` tag instead of `17-jre` to prevent Python 12. ### Why are the changes needed? Two days ago, `eclipse-temurin:17` switched its baseline OS to `Ubuntu 24.04` which brings `Python 3.12`. ``` $ docker run -it --rm eclipse-temurin:17-jre cat /etc/os-release | grep VERSION_ID VERSION_ID="24.04" $ docker run -it --rm eclipse-temurin:17-jammy cat /etc/os-release | grep VERSION_ID VERSION_ID="22.04" ``` Since Python 3.12 supported is added only to Apache Spark 4.0.0, we need to keep using the previous OS, `Ubuntu 22.04`. - #43184 - #43192 ### Does this PR introduce _any_ user-facing change? No. This aims to recover to the same OS for consistent behavior. ### How was this patch tested? Pass the CIs with K8s IT. Currently, it's broken at Python image building phase. - https://github.com/apache/spark/actions/workflows/build_branch34.yml ### Was this patch authored or co-authored using generative AI tooling? No. Closes #47489 from dongjoon-hyun/SPARK-49005-3.4. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
|
Thank you, @viirya ! |
|
Late LGTM |
|
Thank you, @yaooqinn . |
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Aug 7, 2024
…vent Python 3.12 This PR aims to use `17-jammy` tag instead of `17-jre` to prevent Python 12. Two days ago, `eclipse-temurin:17` switched its baseline OS to `Ubuntu 24.04` which brings `Python 3.12`. ``` $ docker run -it --rm eclipse-temurin:17-jre cat /etc/os-release | grep VERSION_ID VERSION_ID="24.04" $ docker run -it --rm eclipse-temurin:17-jammy cat /etc/os-release | grep VERSION_ID VERSION_ID="22.04" ``` Since Python 3.12 supported is added only to Apache Spark 4.0.0, we need to keep using the previous OS, `Ubuntu 22.04`. - apache#43184 - apache#43192 No. This aims to recover to the same OS for consistent behavior. Pass the CIs with K8s IT. Currently, it's broken at Python image building phase. - https://github.com/apache/spark/actions/workflows/build_branch34.yml No. Closes apache#47489 from dongjoon-hyun/SPARK-49005-3.4. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to use
17-jammytag instead of17-jreto prevent Python 12.Why are the changes needed?
Two days ago,
eclipse-temurin:17switched its baseline OS toUbuntu 24.04which bringsPython 3.12.Since Python 3.12 supported is added only to Apache Spark 4.0.0, we need to keep using the previous OS,
Ubuntu 22.04.distutilsusage #43192Does this PR introduce any user-facing change?
No. This aims to recover to the same OS for consistent behavior.
How was this patch tested?
Pass the CIs with K8s IT. Currently, it's broken at Python image building phase.
Was this patch authored or co-authored using generative AI tooling?
No.