[SPARK-8718] [GRAPHX] Improve EdgePartition2D for non perfect square number of partitions #7104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for a given number of parts. To keep compatibility we define default methods that translate between the two implementation options. Made EdgePartition2D use old strategy when we have a perfect square and implement new interface.
| @@ -32,7 +32,7 @@ trait PartitionStrategy extends Serializable { | |||
| object PartitionStrategy { | |||
| /** | |||
| * Assigns edges to partitions using a 2D partitioning of the sparse edge adjacency matrix, | |||
| * guaranteeing a `2 * sqrt(numParts) - 1` bound on vertex replication. | |||
| * guaranteeing a `2 * sqrt(numParts)` bound on vertex replication. | |||
There was a problem hiding this comment.
Note I'm changing the bounds given in the doc since they were never correct for non perfect squares.
|
ok to test |
|
Test build #36081 has finished for PR 7104 at commit
|
|
Can one of the admins verify this patch? |
|
Thanks for the PR and writeup! Merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/aray/e2d/blob/master/EdgePartition2D.ipynb