Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-10581][Docs] Groups are not resolved in scaladoc in sql classes #9148

Closed
wants to merge 1 commit into from
Closed

Conversation

pravingadakh
Copy link
Contributor

Groups are not resolved properly in scaladoc in following classes:

sql/core/src/main/scala/org/apache/spark/sql/Column.scala
sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala
sql/core/src/main/scala/org/apache/spark/sql/functions.scala

@srowen
Copy link
Member

srowen commented Oct 16, 2015

Cool, is that all it takes? you generated the docs and the groups were correct?

@pravingadakh
Copy link
Contributor Author

@srowen Yes, I have verified this in my local environment.

@SparkQA
Copy link

SparkQA commented Oct 16, 2015

Test build #1913 has finished for PR 9148 at commit 52fe806.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 16, 2015

Test build #1914 has finished for PR 9148 at commit 52fe806.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@pravingadakh
Copy link
Contributor Author

@srowen Is there a way to see the generated docs, post a successful build? Just like what we have for master nightly builds http://people.apache.org/~pwendell/spark-nightly/spark-master-docs/latest/api/scala/index.html#org.apache.spark.sql.Column .

@srowen
Copy link
Member

srowen commented Oct 16, 2015

I don't think so, but of course you can build them locally.

@pravingadakh
Copy link
Contributor Author

I have generated scaladoc locally. Attaching the screenshot.
screen shot 2015-10-16 at 9 56 10 pm

Could you please merge this if there aren't any issues with it?

@srowen
Copy link
Member

srowen commented Oct 16, 2015

@pravingadakh while it's trivial, I typically would not merge just 5 hours after you opened it. It's not a hurry, and gives others any chance to look too.

@pravingadakh
Copy link
Contributor Author

@srowen Fair enough. Guess I was super excited for the first commit :)

@rxin
Copy link
Contributor

rxin commented Oct 16, 2015

I've merged this, given it is now 10 hrs ... :)

@rxin
Copy link
Contributor

rxin commented Oct 16, 2015

@pravingadakh do you have an account on JIRA?

@asfgit asfgit closed this in 3d683a1 Oct 16, 2015
asfgit pushed a commit that referenced this pull request Oct 16, 2015
Groups are not resolved properly in scaladoc in following classes:

sql/core/src/main/scala/org/apache/spark/sql/Column.scala
sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala
sql/core/src/main/scala/org/apache/spark/sql/functions.scala

Author: Pravin Gadakh <pravingadakh177@gmail.com>

Closes #9148 from pravingadakh/master.

(cherry picked from commit 3d683a1)
Signed-off-by: Reynold Xin <rxin@databricks.com>
@pravingadakh
Copy link
Contributor Author

@rxin Yes, with username pravingadakh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants