-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-10581][Docs] Groups are not resolved in scaladoc in sql classes #9148
Conversation
…org.apache.spark.sql.Column
Cool, is that all it takes? you generated the docs and the groups were correct? |
@srowen Yes, I have verified this in my local environment. |
Test build #1913 has finished for PR 9148 at commit
|
Test build #1914 has finished for PR 9148 at commit
|
@srowen Is there a way to see the generated docs, post a successful build? Just like what we have for master nightly builds http://people.apache.org/~pwendell/spark-nightly/spark-master-docs/latest/api/scala/index.html#org.apache.spark.sql.Column . |
I don't think so, but of course you can build them locally. |
@pravingadakh while it's trivial, I typically would not merge just 5 hours after you opened it. It's not a hurry, and gives others any chance to look too. |
@srowen Fair enough. Guess I was super excited for the first commit :) |
I've merged this, given it is now 10 hrs ... :) |
@pravingadakh do you have an account on JIRA? |
Groups are not resolved properly in scaladoc in following classes: sql/core/src/main/scala/org/apache/spark/sql/Column.scala sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala sql/core/src/main/scala/org/apache/spark/sql/functions.scala Author: Pravin Gadakh <pravingadakh177@gmail.com> Closes #9148 from pravingadakh/master. (cherry picked from commit 3d683a1) Signed-off-by: Reynold Xin <rxin@databricks.com>
@rxin Yes, with username pravingadakh. |
Groups are not resolved properly in scaladoc in following classes:
sql/core/src/main/scala/org/apache/spark/sql/Column.scala
sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala
sql/core/src/main/scala/org/apache/spark/sql/functions.scala