[SPARK-11787][SPARK-11883] [SQL] [FOLLOW-UP] Cleanup for this patch. #9845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mainly moves SqlNewHadoopRDD to the sql package. There is some state that is shared between core and I've left that in core. This allows some other associated minor cleanup.
| * Note: This is RDD is basically a cloned version of [[org.apache.spark.rdd.NewHadoopRDD]] with | ||
| * changes based on [[org.apache.spark.rdd.HadoopRDD]]. | ||
| */ | ||
| * An RDD that provides core functionality for reading data stored in Hadoop (e.g., files in HDFS, |
There was a problem hiding this comment.
two things...
- you should use intellij simple paste (right click and then "simple paste") to avoid intellij auto formatting the code.
- update your intellij setting so it doesn't use scaladoc format, but use javadoc. in "preferences -> editor -> code style -> scala -> spaces tab -> Other -> uncheck "Use formatting for ScalaDoc2 options"
nongli
changed the title
|
test this please |
|
Test build #46353 has finished for PR 9845 at commit
|
|
Seems there are a few legitimate failures. |
| @transient private val initDriverSideJobFuncOpt: Option[Job => Unit], | ||
| initLocalJobFuncOpt: Option[Job => Unit], | ||
| inputFormatClass: Class[_ <: InputFormat[Void, V]], | ||
| valueClass: Class[V]) |
|
Could you put SPARK-11883 in the title? |
nongli
changed the title
|
test this please |
|
Run 46432 looks slow. |
|
Test build #46432 has finished for PR 9845 at commit
|
|
Thanks - I'm merging this. |
asfgit
pushed a commit
that referenced
this pull request
Nov 20, 2015
This mainly moves SqlNewHadoopRDD to the sql package. There is some state that is shared between core and I've left that in core. This allows some other associated minor cleanup. Author: Nong Li <nong@databricks.com> Closes #9845 from nongli/spark-11787. (cherry picked from commit 58b4e4f) Signed-off-by: Reynold Xin <rxin@databricks.com>
|
Test build #46450 has finished for PR 9845 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly moves SqlNewHadoopRDD to the sql package. There is some state that is
shared between core and I've left that in core. This allows some other associated
minor cleanup.