STORM-1850: State Checkpointing Documentation update #1433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update the documentation following this discussion https://mail-archives.apache.org/mod_mbox/storm-user/201605.mbox/%3CF9D9F747-8431-4A26-9028-BD74C09BCA84%40hortonworks.com%3E
|
+1 |
| @@ -94,6 +94,9 @@ is saved and then the checkpoint tuple is forwarded to the next component. Each | |||
| streams before it saves its state so that the state represents a consistent state across the topology. Once the checkpoint spout receives | |||
| ACK from all the bolts, the state commit is complete and the transaction is recorded as committed by the checkpoint spout. | |||
|
|
|||
| The state checkpointing does not currently checkpoint the state of the spout. Yet, once the states of all bolts are checkpointed and once the checkpoint tuples is acked, the tuples emitted by the spout are acked. | |||
| It also implies that `topology.state.checkpoint.interval.ms` is lower than `topology.message.timeout.secs`. | |||
There was a problem hiding this comment.
once the STATE of all the bolts are checkpointed, and once the checkpoint tuples ARE acked.... by the spout are ALSO acked.
|
+1 once some minor grammar suggestions have been addressed. |
|
Thanks @omallassi this is merged to master and 1.x-branch. |
|
@arunmahadevan Seems like it would be better to apply this to 1.0.x as well. What do you think? |
|
@HeartSaVioR thanks for noticing. The changes are now merged to master, 1.x-branch and 1.0.x-branch. @omallassi thanks for the patch. You may close this PR. |
bipinprasad
pushed a commit
to bipinprasad/storm
that referenced
this pull request
Oct 17, 2019
[YSTORM-6520] Upmerge first batch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the documentation following this discussion
https://mail-archives.apache.org/mod_mbox/storm-user/201605.mbox/%3CF9D9F747-8431-4A26-9028-BD74C09BCA84%40hortonworks.com%3E