STORM-1861 Fix storm script bug to not fork java process #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
+1. @csivaguru can you please squash the commits. It will keep the log a bit cleaner |
|
+1 |
|
+1 the travis failures look unrelated (but we should pull this change into master before 1.x. |
|
+1 |
csivaguru
force-pushed
the
bug_fix/storm_script
branch
from
f0f2e2b
to
5b48272
Compare
|
@csivaguru merged this PR f0f2e2b . Not sure why this PR not closed yet. Feel free to close it and open a another one for master branch. |
|
Closing the Pull Request |
bipinprasad
pushed a commit
to bipinprasad/storm
that referenced
this pull request
Oct 17, 2019
[YSTORM-6520] Upmerge final merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.