[STORM-1872]Release Jedis connection when topology shutdown #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,4 +36,10 @@ | |||
| * @param jedisCommands borrowed instance | |||
| */ | |||
| void returnInstance(JedisCommands jedisCommands); | |||
|
|
|||
| /** | |||
| * Release Jedis Connection | |||
There was a problem hiding this comment.
It should be closing container, not Jedis connection.
There was a problem hiding this comment.
update to "Release Container"
|
The change looks good. +1 |
|
@darionyaphet Could you rebase it to recent master to trigger build? Thanks in advance! |
|
@HeartSaVioR done ! travis ci started and working . |
bipinprasad
pushed a commit
to bipinprasad/storm
that referenced
this pull request
Oct 17, 2019
YSTORM-6497 report v2 metrics api in metrics tick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STORM-1872
Strom Redis connect should be release when topology shutdown .