[STORM-2093] Fix permissions in multi-tenant, secure mode #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please make commit message explain the commit and/or add JIRA issue as prefix. Commit message is not clear on which thing this commit fixes and how it helps. |
|
I agree with @HeartSaVioR could you please change the commit message to something more like the pull request title? should do it for you. |
|
Any updates here? |
|
Sorry it's taken me so long to get back to this, @HeartSaVioR @revans2. Amended commit message. |
|
screwed up merge. Closing. It'll be easier to do this on a fresh branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heap dumps created on OOM, when served through the logviewer in secure multitenant configurations have permssions set such that the logviewer cannot read them.
This change checks permissions in this case before serving and then runs the worker-launcher to enable the logviewer to serve them.