STORM-2098: DruidBeamBolt: Pass DruidConfig.Builder as constructor argument #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@satishd pinging for review. |
satishd
reviewed
Sep 16, 2016
| @@ -52,11 +52,11 @@ public static void main(String[] args) throws Exception { | |||
|
|
|||
| topologyBuilder.setSpout("event-gen", new SimpleSpout(), 5); | |||
| DruidBeamFactory druidBeamFactory = new SampleDruidBeamFactoryImpl(new HashMap<String, Object>()); | |||
| DruidConfig druidConfig = DruidConfig.newBuilder().discardStreamId(DruidConfig.DEFAULT_DISCARD_STREAM_ID).build(); | |||
| DruidConfig.Builder bulder = DruidConfig.newBuilder().discardStreamId(DruidConfig.DEFAULT_DISCARD_STREAM_ID); | |||
There was a problem hiding this comment.
typo nit: variable name should be builder
There was a problem hiding this comment.
Thanks for the review. Updated the PR.
|
+1 LGTM |
|
+1 on this, but it might be better for Flux to handle builder method, just like Spring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.