STORM-2109: Treat Supervisor CPU/MEMORY Configs as Numbers #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
The travis failure is unrelated it is yet again a maven issue downloading something that should be there. @knusbaum @kishorvpatil could you please take a look? |
|
+1 |
| ret.put(Config.SUPERVISOR_CPU_CAPACITY, cpu); | ||
| Number mem = (Number) (conf.get(Config.SUPERVISOR_MEMORY_CAPACITY_MB)); | ||
| ret.put(Config.SUPERVISOR_MEMORY_CAPACITY_MB, mem.doubleValue()); | ||
| Number cpu = (Number) (conf.get(Config.SUPERVISOR_CPU_CAPACITY)); |
There was a problem hiding this comment.
Possibility of NPE here. Can we use utils method to do this.
There was a problem hiding this comment.
Good point. Utils.getDouble() with default value would be safer.
There was a problem hiding this comment.
The NPE should never happen if defaults.yaml is configured correctly, but I will still make the change.
|
Rebased and addressed the review comments. |
|
+1 again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.