Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STORM-2120 - Emit to _spoutConfig.outputStreamId #1701

Merged
merged 1 commit into from
Sep 23, 2016
Merged

STORM-2120 - Emit to _spoutConfig.outputStreamId #1701

merged 1 commit into from
Sep 23, 2016

Conversation

aichow
Copy link
Contributor

@aichow aichow commented Sep 21, 2016

Even though KafkaSpout.declareOutputFields declaresStream using outputStreamId (if present), the message gets emitted to a stream matching the Kafka topic it was read from. Looks like it may have been a merge conflict between the fix for STORM-1210 and STORM-1379.

Even though KafkaSpout.declareOutputFields declaresStream using outputStreamId (if present), the message gets emitted to a stream matching the Kafka topic it was read from. Looks like it may have been a merge conflict between the fix for STORM-1210 and STORM-1379.
@HeartSaVioR
Copy link
Contributor

HeartSaVioR commented Sep 22, 2016

+1 Nice finding.
storm-kafka CI build fails but looks unrelated.

Btw, IMO this bug is worth to file an issue, since this bug is affecting to various official releases from 1.0.0 to 1.0.2.
@aichow Could you please file an issue and add issue name to prefix of PR's title? I can handle it if you mind.

@aichow aichow changed the title Emit to _spoutConfig.outputStreamId STORM-2120 - Emit to _spoutConfig.outputStreamId Sep 22, 2016
@aichow
Copy link
Contributor Author

aichow commented Sep 22, 2016

@HeartSaVioR Not sure if I tagged the JIRA issue with the right Affects Versions, so feel free to edit as appropriate. Thanks!

@asfgit asfgit merged commit 09d9ea1 into apache:master Sep 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants