STORM-2215: validate blobs are present before submitting #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeartSaVioR
reviewed
Nov 23, 2016
| @@ -587,4 +592,10 @@ private static double getMaxExecutorMemoryUsageForTopo(StormTopology topology, M | |||
| } | |||
| return largestMemoryOperator; | |||
| } | |||
|
|
|||
| private static Set<String> getListOfKeysFromBlobStore(Map<String, Object> stormConf) { | |||
| NimbusBlobStore client = new NimbusBlobStore(); | |||
There was a problem hiding this comment.
Need to guarantee calling client.shutdown().
| @@ -1338,6 +1339,26 @@ public static void handleUncaughtException(Throwable t) { | |||
| } | |||
| } | |||
|
|
|||
| public static void validateTopologyBlobStoreMap(Map stormConf, Set<String> blobStoreKeys) throws InvalidTopologyException { | |||
| boolean containsAllBlobs = true; | |||
There was a problem hiding this comment.
Minor: We're adding missing keys to Set so no need to have additional flag. missingKeys.size() > 0 is same to containsAllBlobs == false.
HeartSaVioR
reviewed
Nov 23, 2016
|
@HeartSaVioR I rebased and addressed the review comments, but I want to merge in #1744 first and then I will update this one again. |
|
#1744 is in and this is rebased |
|
+1 Thanks for the work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.