fix: KafkaSpout is blocked in AutoCommitMode #1863
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What's the issue? When Storm topology is run on 'At-Most-Once' mode, with ack executor=0, KafkaSpout cannot emit records after some time. What's the cause? Function poll() controls whether it need to pull more data from Kafka cluster. With the condition `!waitingToEmit() && numUncommittedOffsets < maxUncommittedOffsets`, it's always `FALSE` after reaching threshold, as `numUncommittedOffsets` is creasing and never reset on 'At-Most-Once' mode. What's the solution? I change the condition to `!waitingToEmit() && (numUncommittedOffsets < maxUncommittedOffsets || consumerAutoCommitMode)`, that return `TRUE` with AutoCommitMode regarding of UnCommittedOffset, see the comments inline. Also, it's not required to track emitted(msgId) and numUncommittedOffsets with AutoCommitMode .
|
Nice find :) You should go to https://issues.apache.org/jira/ and create an issue for this. Then rename this PR to mention the jira issue number (see the other open PRs for an example). The commit message should probably also mention the issue number. The fix itself looks fine to me. |
sync-up code
|
@xumingmin Could you rebase this? STORM-2225 touches many places on storm-kafka-client so you might need to check it's still valid. |
|
@srdo I create STORM-2340, @HeartSaVioR , let me check with the latest code, and open a new pull request |
|
@HeartSaVioR The issue is still there, so I create a new pull request #1919 after rebase, |
|
close this one, use #1919 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the issue?
When Storm topology is run on 'At-Most-Once' mode, with ack executor=0, KafkaSpout cannot emit records after some time.
What's the cause?
Function poll() controls whether it need to pull more data from Kafka cluster. With the condition
!waitingToEmit() && numUncommittedOffsets < maxUncommittedOffsets, it's alwaysFALSEafter reaching threshold, asnumUncommittedOffsetsis creasing and never reset on 'At-Most-Once' mode.What's the solution?
I change the condition to
!waitingToEmit() && (numUncommittedOffsets < maxUncommittedOffsets || consumerAutoCommitMode), that returnTRUEwith AutoCommitMode regarding of UnCommittedOffset, see the comments inline.Also, it's not required to track emitted(msgId) and numUncommittedOffsets with AutoCommitMode .