Storm-2236 Kafka Spout with manual partition management for 1.x-branch #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@harshach This is a commit for 1.x-branch without function interface, could you please help to merge it? |
|
+1. Thanks @liurenjie1024 |
harshach
reviewed
Jan 19, 2017
| @@ -0,0 +1,16 @@ | |||
| package org.apache.storm.kafka.spout; | |||
There was a problem hiding this comment.
can you add the Apache License at the top.
|
@liurenjie1024 TopicPartitionComparator missing Apache License. Can you add that. |
|
+1 |
|
Travis CI build failure is unrelated and fix is available (#1887) @liurenjie1024 |
liurenjie1024
force-pushed
the
STORM-2236-1.x
branch
from
eaeb639
to
31e063f
Compare
liurenjie1024
force-pushed
the
STORM-2236-1.x
branch
from
31e063f
to
c9b6653
Compare
|
@HeartSaVioR Commits squashed, please help to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title says.