STORM-2344 Flux YAML File Viewer for Nimbus UI #1922
Conversation
| @@ -0,0 +1,139 @@ | |||
| <html> | |||
There was a problem hiding this comment.
Missing apache license. And I guess we may need a link from storm ui homepage to flux.html.
There was a problem hiding this comment.
@vesense I thought someone will ask for that :D
Just added both.
There was a problem hiding this comment.
Also, should we plan on back porting this to 0.10.x and 1.x?
There was a problem hiding this comment.
I think @vesense means that Storm UI index page should have a link to go to flux page. You're adding reverse link, which is already missing.
And I think we might want to port back to 1.x but not necessary to 1.0.x. Let's keep the bugfix version line.
There was a problem hiding this comment.
Sorry I misunderstood. @HeartSaVioR not sure what location in the homepage do we want to put the forward link?
One option could be to skip the link in homepage and provide it via Ambari View.
There was a problem hiding this comment.
I have the same idea as @HeartSaVioR 😄
There was a problem hiding this comment.
Added a link on the top right hand side after the username place holder. Here's the icon https://github.com/ambud/storm/blob/af8ed339cb3896100dabe3619c0fba2d19165dff/storm-core/src/ui/public/images/flux.png
Y for YAML and also for Flux Capacitor from Back to the future 💯
Please let me know if this works.
There was a problem hiding this comment.
Not sure which is better between F (for Flux) and Y (for Yaml). I guess the question could be changed to is flux yaml viewer flux yaml viewer, or flux yaml viewer. What do you think?
There was a problem hiding this comment.
And posting screenshot to the comment would help us to see.
There was a problem hiding this comment.
|
@ambud Could you update it? |
|
And some javascript files like esprima.js are not minimized. Is there any reason not to do? |
Adding apache license and link to Storm Homepage Adding links from storm nimbus homepage Adding License for Javascript libraries. Using min js for esprima Adding license files
Couldn't find a min.js for dagre |
|
js files are licensed under BSD-2 and MIT, seems OK. +1 from me. Thanks! |
Adding capabilities to visualize the Storm Flux YAML files before submitting the topology would be helpful for developers and operations.