STORM-2387 Handle tick tuples properly for Bolts in external modules (1.x) #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeartSaVioR
force-pushed
the
STORM-2387-1.x
branch
from
8a5b629
to
fe498d2
Compare
* introduce BaseTickTupleAwareRichBolt which makes logic branches for tick tuple and non-tick tuple * apply BaseTickTupleAwareRichBolt to Bolts in external modules * also remove ack for tick tuples since it's not necessary
HeartSaVioR
force-pushed
the
STORM-2387-1.x
branch
from
fe498d2
to
d33ea90
Compare
|
I'll also merge this given that #1978 got +1 and this is for porting back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also fixed some mixing indentations. We should introduce code style soon.
For master branch: #1978