STORM-2396: setting interrupted status back before throwing a RuntimeException #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeartSaVioR
reviewed
Mar 7, 2017
| @@ -134,6 +134,8 @@ | |||
| import clojure.lang.Keyword; | |||
| import clojure.lang.RT; | |||
|
|
|||
| import static java.lang.Thread.currentThread; | |||
There was a problem hiding this comment.
Thread.currentThread() is widely used so it's more readable than currentThread() for me.
There was a problem hiding this comment.
Okay, will change.
HeartSaVioR
reviewed
Mar 7, 2017
| @@ -356,13 +358,14 @@ public static void sleep(long millis) { | |||
| try { | |||
| Time.sleep(millis); | |||
| } catch(InterruptedException e) { | |||
| currentThread().interrupt(); | |||
There was a problem hiding this comment.
How it will collaborate with throwing RuntimeException? Are we assuming that caller catches RuntimeException? Just not clear that how it works together.
There was a problem hiding this comment.
Here's a suboptimal example of a loop that will never exit as intended
while(!currentThread.isInterrupted()) {
execute();
}
...
void execute() {
try {
... // RE may be thrown here
Utils.sleep(1000);
... // and here
} catch (RuntimeException e)
log.error(e);
}
}
|
+1 |
1 similar comment
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in JIRA the interrupted flag is not set back after catching InterruptedException and wrapping it into a RuntimeException so any code dependent on checking the interrupted status will not work properly in case the RuntimeException doesn't make it up the stack.