Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STORM-2422: Reduce the size of a serialized trident topology #2016

Merged
merged 1 commit into from
Mar 20, 2017

Conversation

revans2
Copy link
Contributor

@revans2 revans2 commented Mar 17, 2017

For now I only plan to do this for master. If someone else runs into this issue I am happy to backport it to other versions of storm.

Copy link
Contributor

@kishorvpatil kishorvpatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@arunmahadevan arunmahadevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it observed in some real topology? Would expect this to manifest only with a really big graph and large number of sub-topology bolts.

+1 for the changes.

@revans2
Copy link
Contributor Author

revans2 commented Mar 17, 2017

@arunmahadevan yes this is showing up in a real topology (part of monitoring and alerting at Yahoo). And yes some of these topologies are really large. They are machine generated from a number of different user provided configurations, which is why it can grow to be so large. Having fewer big topologies instead of many small topologies makes them more efficient because they only have to read/process the metrics once. There are ways to work around it on the user side, but this felt like a cleaner solution overall.

@HeartSaVioR
Copy link
Contributor

+1

@asfgit asfgit merged commit 525f14f into apache:master Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants