[STORM-2467] Use explicit charset when decoding from array backed buffer #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice find. The change LGTM. You should create an issue for this at https://issues.apache.org/jira/browse/STORM so the bugfix gets tracked. Then rename this PR and the commit message to include the issue number (example https://github.com/apache/storm/pull/2057/commits). |
We had the case that this broke encoding for us because it used the default system locale. Given the fact that this code uses an explicit encoding for the other case and that it evolved from something that always used an explicit encoding I believe this is more correct.
marcust
changed the title
|
@srdo Done |
|
+1 Nice finding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had the case that this broke encoding for us because it used the default
system locale. Given the fact that this code uses an explicit encoding for the
other case and that it evolved from something that always used an explicit
encoding I believe this is more correct.