Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[STORM-2480] principle should be modified to principal #2077

Merged
merged 1 commit into from
Apr 19, 2017
Merged

[STORM-2480] principle should be modified to principal #2077

merged 1 commit into from
Apr 19, 2017

Conversation

liu-zhaokun
Copy link
Contributor

https://issues.apache.org/jira/browse/STORM-2480
As "principal" could be right in kerberos, "principle" should be modified to "principal".

@liu-zhaokun
Copy link
Contributor Author

Hello, @HeartSaVioR
Are you available to help me review this PR?

@liu-zhaokun
Copy link
Contributor Author

Hello, @vesense
Are you available to help me review this PR?

@liu-zhaokun
Copy link
Contributor Author

@HeartSaVioR
I am so sorry to bother you,could help me to check this PR?

@liu-zhaokun
Copy link
Contributor Author

@vesense
I am so sorry to bother you,could help me to check this PR?

@vesense
Copy link
Member

vesense commented Apr 19, 2017

+1

@asfgit asfgit merged commit 3d61967 into apache:master Apr 19, 2017
@liu-zhaokun
Copy link
Contributor Author

Hi, @vesense long time no see.How are you?
Thanks for your reply,but also will trouble you to help me merge it.

@vesense
Copy link
Member

vesense commented Apr 19, 2017

Merged, and I added you to the contributors list.

@liu-zhaokun
Copy link
Contributor Author

@vesense
Will I find my name here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liu-zhaokun @vesense @asfgit