Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STORM-1642: Rethrow exception on serialization error and kill worker #2095

Merged
merged 1 commit into from
Jun 9, 2017
Merged

STORM-1642: Rethrow exception on serialization error and kill worker #2095

merged 1 commit into from
Jun 9, 2017

Conversation

govind-menon
Copy link
Contributor

No description provided.

@govind-menon
Copy link
Contributor Author

@knusbaum Pushback of internal change.

@knusbaum
Copy link
Contributor

knusbaum commented May 1, 2017

+1

@govind-menon
Copy link
Contributor Author

@revans2 Review and merge?

revans2
revans2 approved these changes May 1, 2017
View reviewed changes
Copy link
Contributor

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am +1 on this, but we need to work out the differences with #2076

@govind-menon govind-menon mentioned this pull request May 1, 2017
Closed
revans2
revans2 approved these changes Jun 9, 2017
View reviewed changes
Copy link
Contributor

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@asfgit asfgit merged commit 4f9d5c0 into apache:master Jun 9, 2017
@govind-menon govind-menon deleted the STORM-1642 branch June 9, 2017 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knusbaum knusbaum knusbaum approved these changes

@revans2 revans2 revans2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@govind-menon @knusbaum @revans2 @asfgit