Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STORM-2564] We should provide a template for storm-cluster-auth.yaml #2170

Merged
merged 1 commit into from
Jun 29, 2017

Conversation

liu-zhaokun
Copy link
Contributor

https://issues.apache.org/jira/browse/STORM-2564
As the configuration which named storm.zookeeper.auth.payload should be filled in "storm-cluster-auth.yaml",and there isn't such a file.So, I think we should provide a template for storm-cluster-auth.yaml.

@liu-zhaokun
Copy link
Contributor Author

@vesense
Could you help me review this PR?

@liu-zhaokun
Copy link
Contributor Author

@HeartSaVioR
Hello,are you available to help me review this PR?

@HeartSaVioR
Copy link
Contributor

If this is needed, why not adding storm.yaml.example and commenting it out? I don't think users want to copy a line from template file and paste to their storm.yaml.

@liu-zhaokun
Copy link
Contributor Author

@HeartSaVioR
It says "Note that if this is set to something with a secret (as when using digest authentication) then it should only be set in the storm-cluster-auth.yaml file." in Config.java,line 1082. So I think we should provide
a template.

@liu-zhaokun
Copy link
Contributor Author

@HeartSaVioR
Users needn't copy the configuration,storm.zookeeper.auth.payload, from storm-cluster-auth.yaml.template and paste to their storm.yaml.They only should add this configuration to storm-cluster-auth.yaml if they need.

@HeartSaVioR
Copy link
Contributor

@liu-zhaokun Thanks for correcting. You're right. I'm not aware of that. +1

@liu-zhaokun
Copy link
Contributor Author

@HeartSaVioR
Thanks for your reply,if possible, please help me merge it as soon as possible,because this PR has been created for a long time.

@asfgit asfgit merged commit bf8198d into apache:master Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants