STORM-2369 [storm-redis] Use binary type for State management #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just update the PR to make equivalent to #1950 |
* introduce new command interface and relevant containers * new command interface will contain both binary and string commands in near future * change RedisKeyValue to use byte[] for State key and value management instead of String * get rid of Base64 encode/decode on RedisEncoder, and also SafeEncoder.encode() in Jedis internal * users can select either Redis single server or Redis Cluster by passing JedisPoolConfig or JedisClusterConfig * implement binary based KV state iterator * Provide a tool to migrate old base64 state to the new binary state * migration tool is placed to storm-redis-examples * the module is easy to create uber jar hence easy to run the class * document how to build and use migration tool * address review comments * mostly generalizing via creating new interfaces or base classes * also fix some checkstyle issues
|
Filed an issue for versioning state: https://issues.apache.org/jira/browse/STORM-2605 |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is equivalent to #1950. Please note that there're some other changes for fixing checkstyle. I didn't address all of them, but my patch exceeded the limit so I ended up to fix some in this patch.