Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STORM-2672] Expose a metric for calls to reportError() #2255

Merged
merged 1 commit into from
Aug 3, 2017

Conversation

Ethanlm
Copy link
Contributor

@Ethanlm Ethanlm commented Aug 2, 2017

See: https://issues.apache.org/jira/browse/STORM-2672

Add a metric for calls to reportError.

@revans2
Copy link
Contributor

revans2 commented Aug 2, 2017

Could you update the metrics documentation to include the new metric? This is new and under docs/Metrics.md

otherwise the change looks good.

@Ethanlm
Copy link
Contributor Author

Ethanlm commented Aug 2, 2017

Yes. Will do

Copy link
Contributor

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@asfgit asfgit merged commit 96ad079 into apache:master Aug 3, 2017
@Ethanlm Ethanlm deleted the STORM-2672 branch August 4, 2017 13:24
@Ethanlm
Copy link
Contributor Author

Ethanlm commented Aug 8, 2017

@roshannaik Could you please let me know what issues you are talking about?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants