STORM-455 Report error-level messages from ShellBolt children #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is fine, we have rate limiting so we should not overwhelm ZK too badly. +1, I'll merge this in |
|
Or I will check it in once the network here stops going crazy. |
knusbaum
pushed a commit
to knusbaum/incubator-storm
that referenced
this pull request
Feb 11, 2015
[BUG 7040521] Fix for netty client reconnect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is that it'd be nice to see reported errors from
ShellBoltin the Storm UI, and now that we have support for multiple logging levels, we can assume thaterrorlevel messages are errors to be reported.