Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STORM-2757] Fix broken log links when HTTPS is in use #2348

Merged
merged 1 commit into from
Sep 28, 2017

Conversation

Ethanlm
Copy link
Contributor

@Ethanlm Ethanlm commented Sep 26, 2017

jira: https://issues.apache.org/jira/browse/STORM-2757

We have HTTPS configs for UI and Logviewer. But it's not working properly.

We should expect:

UI LogViewer scheme of log links port of log links
HTTP HTTP http logviewer.port
HTTP HTTPS https logviewer.https.port
HTTPS HTTPS https logviewer.https.port
HTTPS HTTP should not work should not work

@Ethanlm
Copy link
Contributor Author

Ethanlm commented Sep 26, 2017

Tested it manually with all four combinations by visiting pages/links.

UI LogViewer all UI pages Nimbus log Supervisor log Worker log Event Log dumps and download logviewer search deap search
HTTP HTTP
HTTP HTTPS
HTTPS HTTPS
HTTPS HTTP x x x x x x x

✓ means working properly. x means not working.

These are expected behaviors.

Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Thanks for the fix.

@asfgit asfgit merged commit ab6abf9 into apache:master Sep 28, 2017
@Ethanlm Ethanlm deleted the STORM-2757 branch September 28, 2017 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants