STORM-2787: storm-kafka-client KafkaSpout method onPartitionsRevoked(...) should set initialized flag independently of processing guarantees #2387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for the change. It might be good to add a test that demonstrates the fix as well if possible. |
|
Looks like 1.1.x branch also needs the patch, and that branch shouldn't be on top of STORM-2781. @hmcl Could you craft a new PR against 1.1.x-branch if my understanding is right? Thanks in advance. |
- Define processing guarantees as AT_LEAST_ONCE, AT_MOST_ONCE, NONE - Refactor method name from setForceEnableTupleTracking to setTupleTrackingEnforced - Throw IllegalStateException instead of IllegalArgumentException if spout attempts to emit an already committed message - Update documentation to reflect these changes
…...) should set initialized flag independently of processing guarantees
hmcl
force-pushed
the
Apache_master_STORM-2787_KSInitFlag
branch
from
12473ed
to
0b547d3
Compare
|
@srdo @HeartSaVioR I have incorporated the code review changes of the depending patch. It should be good to merge. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit for STORM-2787 is on top of STORM-2781 to make it easier to merge later. Please review only STORM-2787. Once the code reviews for STORM-2781 have been agreed upon I will incorporate them in this patch as well.