Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[STORM-2804] Fix TopoCache is not caching ACLs correctly problem #2404

Merged
merged 1 commit into from
Nov 9, 2017
Merged

[STORM-2804] Fix TopoCache is not caching ACLs correctly problem #2404

merged 1 commit into from
Nov 9, 2017

Conversation

Ethanlm
Copy link
Contributor

@Ethanlm Ethanlm commented Nov 8, 2017

https://issues.apache.org/jira/browse/STORM-2804

The ACLs might change during store.createBlob() but it's not populated to topos.put(), which leads to permission problem.

Tested it manually.

@Ethanlm
Copy link
Contributor Author

Ethanlm commented Nov 9, 2017

Don't know why it failed. The build passed on my VM.

HeartSaVioR
HeartSaVioR approved these changes Nov 9, 2017
View reviewed changes
Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Nice finding.

@asfgit asfgit merged commit 3578cf8 into apache:master Nov 9, 2017
@Ethanlm Ethanlm deleted the STORM-2804 branch February 23, 2018 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeartSaVioR HeartSaVioR HeartSaVioR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ethanlm @HeartSaVioR @asfgit