Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STORM-2872: Fix for wouldFit and rebalance as part of GenericResourceAwareScheduling changes #2456

Merged
merged 1 commit into from
Jan 2, 2018
Merged

STORM-2872: Fix for wouldFit and rebalance as part of GenericResourceAwareScheduling changes #2456

merged 1 commit into from
Jan 2, 2018

Conversation

govind-menon
Copy link
Contributor

@govind-menon govind-menon commented Dec 13, 2017 •
edited
Loading

No description provided.

kishorvpatil
kishorvpatil reviewed Dec 14, 2017
View reviewed changes
storm-server/src/test/java/org/apache/storm/scheduler/resource/TestResourceAwareScheduler.java Outdated
@@ -640,6 +641,150 @@ public void testHeterogeneousCluster() {
//end of Test3
}

@Test
public void testHeterogeneousClusterwithGras() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refactor to avoid duplicate code.

@HeartSaVioR
Copy link
Contributor

Some guidelines for contribution:

  1. Please file an issue to Apache JIRA, rather than referring internal issue.
  2. Please make your title of PR (and summary of JIRA) self-describing. Not only code change is important. Leaving context against the code change is more important for future.

@govind-menon govind-menon changed the title YSTORM-4457: Fix for wouldFit STORM-2725: Fix for wouldFit Dec 19, 2017
@govind-menon govind-menon changed the title STORM-2725: Fix for wouldFit STORM-2725: Fix for wouldFit and rebalance as part of GenericResourceAwareScheduling changes Dec 19, 2017
@govind-menon govind-menon reopened this Dec 19, 2017
@govind-menon govind-menon force-pushed the YSTORM-4457-II branch 2 times, most recently from cf3c3ce to 9871ef3 Compare December 20, 2017 18:46
@HeartSaVioR
Copy link
Contributor

I'm sorry but what does "Fix for wouldFit" mean?
Please raise a new issue instead of using already-resolved issue.

@govind-menon govind-menon changed the title STORM-2725: Fix for wouldFit and rebalance as part of GenericResourceAwareScheduling changes STORM-2872: Fix for wouldFit and rebalance as part of GenericResourceAwareScheduling changes Dec 28, 2017
@govind-menon
Copy link
Contributor Author

@HeartSaVioR apologies for lack of description. I filed a new subtask and added a description

@HeartSaVioR
Copy link
Contributor

Thanks for addressing. Please change commit and PR title as well.

@govind-menon
Copy link
Contributor Author

@HeartSaVioR Done. As an aside the test failure appears to be on the master branch as well.

revans2
revans2 approved these changes Jan 2, 2018
View reviewed changes
Copy link
Contributor

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@asfgit asfgit merged commit 4fd02ca into apache:master Jan 2, 2018
asfgit pushed a commit that referenced this pull request Jan 2, 2018
Merge branch 'YSTORM-4457-II' of https://github.com/govind-menon/storm …
2846417 
…into STORM-2872

STORM-2872: Fix for wouldFit and rebalance as part of
GenericResourceAwareScheduling changes

This closes #2456
@govind-menon govind-menon deleted the YSTORM-4457-II branch January 2, 2018 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishorvpatil kishorvpatil kishorvpatil left review comments

@revans2 revans2 revans2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@govind-menon @HeartSaVioR @revans2 @kishorvpatil @asfgit