[STORM-2897]Optimize defaults.yaml by removing the zeromq configurations and adding some annotations #2513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny0405
reviewed
Jan 18, 2018
| @@ -193,11 +193,7 @@ backpressure.disruptor.low.watermark: 0.4 | |||
| backpressure.znode.timeout.secs: 30 | |||
| backpressure.znode.update.freq.secs: 15 | |||
|
|
|||
| zmq.threads: 1 | |||
| zmq.linger.millis: 5000 | |||
There was a problem hiding this comment.
So why just remove zero-mq config? Is there any other deprecated conf need to be removed?
|
I've only found these yet. |
|
@liuxianjiao |
liuxianjiao
changed the title
|
@HeartSaVioR Thanks for your advice. I‘ve already done it. |
|
@HeartSaVioR Thanks!Could you help me to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/STORM-2897
Optimize defaults.yaml by removing the redundancy and making the annotation more perfect.I remove the zeromq configurations and add some annotations.This make the reader somewhat less confused.In this way, the defaults.yaml could be more clear and readable.