Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STORM-2983] fix the issue that the inter-worker transfer thread is not spun up on some cases on RAS cluster #2614

Merged
merged 1 commit into from
Apr 5, 2018

Conversation

Ethanlm
Copy link
Contributor

@Ethanlm Ethanlm commented Mar 30, 2018

https://issues.apache.org/jira/browse/STORM-2983

Because the number of workers are dynamically calculated on RAS and is not populated to SupervisorStormConf, by default topologyConf.get(Config.TOPOLOGY_WORKERS) returns 1 and the transferThread is not launched. Some topologies like

bin/storm jar storm-loadgen-*.jar org.apache.storm.loadgen.ThroughputVsLatency --spouts 1 --splitters 2 --counters 1 -c topology.debug=true

on RAS cluster are not working properly.

@Ethanlm
Copy link
Contributor Author

Ethanlm commented Mar 30, 2018

not sure why the build failed. Succeeded on my mac.

Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 I think it's fair.

Copy link
Contributor

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

…ot spun up on some cases on RAS cluster

Because the number of workers are dynamically calculated on RAS and is not populated to SupervisorStormConf
Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Even better.

@asfgit asfgit merged commit 5516f29 into apache:master Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants