Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STORM-3206] validate topoConf only against Config.java during submission #2823

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

Ethanlm
Copy link
Contributor

@Ethanlm Ethanlm commented Sep 11, 2018

Storm should only validate client-side conf when user submits a topology.

Otherwise settings like logviewer.https.port=-1 will fail the submission.

Copy link
Contributor

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@kishorvpatil kishorvpatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asfgit asfgit merged commit 45fc760 into apache:master Sep 12, 2018
asfgit pushed a commit that referenced this pull request Sep 12, 2018
…ORM-3206

STORM-3206: validate topoConf only against Config.java during submission

This closes #2823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants