Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STORM-3263] Fix sorting by owner resources in the UI #2888

Merged
merged 1 commit into from
Oct 22, 2018

Conversation

jacobtolar
Copy link
Contributor

@jacobtolar jacobtolar commented Oct 19, 2018

See the jira for the before/after screenshot. I tested with the following in the chrome console:

myData = $('#owner-summary-table').DataTable().data()
$('#owner-summary-table').DataTable().destroy()

$.extend( $.fn.dataTableExt.oSort, {
  "resource-num-pre": function(raw) {
    if (raw == 'N/A') {
      return Number.NEGATIVE_INFINITY;
    } else {
      return $.fn.dataTableExt.oSort['num-pre'](raw);
    }
  },
  "resource-num-asc": $.fn.dataTableExt.oSort['num-asc'],
  "resource-num-desc": $.fn.dataTableExt.oSort['num-desc']
});

// paste in new definition of makeOwnerSummaryTable as myOwnerTable...

myOwnerTable('#owner-summary-table', '#owner-summary')

Copy link
Contributor

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@asfgit asfgit merged commit 6b03737 into apache:master Oct 22, 2018
asfgit pushed a commit that referenced this pull request Oct 22, 2018
… STORM-3263

STORM-3263: Fix sorting by owner resources in the UI

This closes #2888
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants