Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STORM-3297 prevent supervisor restart when no nimbus leader exists #2920

Merged
merged 1 commit into from
Dec 12, 2018
Merged

STORM-3297 prevent supervisor restart when no nimbus leader exists #2920

merged 1 commit into from
Dec 12, 2018

Conversation

agresch
Copy link
Contributor

@agresch agresch commented Dec 5, 2018

No description provided.

kishorvpatil
kishorvpatil reviewed Dec 5, 2018
View reviewed changes
storm-server/src/main/java/org/apache/storm/metricstore/NimbusMetricProcessor.java
@@ -24,7 +24,7 @@
public void processWorkerMetrics(Map<String, Object> conf, WorkerMetrics metrics) throws MetricException {
try (NimbusClient client = NimbusClient.getConfiguredClient(conf)) {
client.getClient().processWorkerMetrics(metrics);
} catch (TException e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we instead of handling all exceptions, be more specific on capturing NimbusLeaderNotFoundException ?
catch (TException | NimbusLeaderNotFoundException e)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

kishorvpatil
kishorvpatil approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@kishorvpatil kishorvpatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

danny0405
danny0405 approved these changes Dec 6, 2018
View reviewed changes
Copy link

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, this is a functional degradation if we restart supervisor cause of nimbus dead.

@srdo
Copy link
Contributor

srdo commented Dec 11, 2018

+1, please squash to one commit and I'll merge :)

@agresch
Copy link
Contributor Author

agresch commented Dec 11, 2018

@srdo - done

@asfgit asfgit merged commit afa173f into apache:master Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishorvpatil kishorvpatil kishorvpatil approved these changes

@danny0405 danny0405 danny0405 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@agresch @srdo @kishorvpatil @danny0405 @asfgit