Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STORM-3374 remove unnecessary stacktrace from log #2993

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

agresch
Copy link
Contributor

@agresch agresch commented Apr 4, 2019

No description provided.

@srdo
Copy link
Contributor

srdo commented Apr 5, 2019

Do you have some examples of the kind of exception that gets caught here? It seems weird that we only log this line at info level, since we already filter connection errors out.

@agresch
Copy link
Contributor Author

agresch commented Apr 5, 2019

@srdo
Copy link
Contributor

srdo commented Apr 5, 2019

Thanks. Maybe we could log the stack trace at debug or trace level, and keep the info level log without a stack trace? The reason I'm worried about removing it is that the exception handler catches any kind of exception coming out of the Netty channel handlers, so I don't think we can be sure the exception is innocent.

Alternatively we could log IOExceptions at info level without stack trace (with stack trace at debug/trace level maybe), and any other type of exception at error level?

@agresch
Copy link
Contributor Author

agresch commented Apr 15, 2019

@srdo - updated as you suggested

@srdo
Copy link
Contributor

srdo commented Apr 15, 2019

+1, thanks.

@srdo
Copy link
Contributor

srdo commented Apr 15, 2019

Please squash and I'll merge

@agresch
Copy link
Contributor Author

agresch commented Apr 15, 2019

@srdo - squashed

Copy link
Contributor

@kishorvpatil kishorvpatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asfgit asfgit merged commit 0dafa83 into apache:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants