STORM-3472: Add tests missing for STORM-3411, make the download file name generat… #3091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name generation code less error prone
srdo
changed the title
|
Sorry for the late reply. I will take a look when I get a chance. |
Ethanlm
reviewed
Jul 26, 2019
| } catch (NullPointerException e) { | ||
| fname = file.getName(); | ||
| } | ||
| public static Response buildDownloadFile(String host, String contentDispositionName, |
There was a problem hiding this comment.
The String host parameter can be removed.
bipinprasad
pushed a commit
to bipinprasad/storm
that referenced
this pull request
Oct 17, 2019
…name generat… (apache#3091) * STORM-3472: Add tests missing for STORM-3411, make the download file name generation code less error prone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ion code less error prone