Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STORM-3520: Fixes drpc-client function argument validation in Storm CLI #3138

Merged
merged 1 commit into from
Oct 11, 2019
Merged

STORM-3520: Fixes drpc-client function argument validation in Storm CLI #3138

merged 1 commit into from
Oct 11, 2019

Conversation

govind-menon
Copy link
Contributor

No description provided.

Ethanlm
Ethanlm approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@Ethanlm Ethanlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 assuming build passed.

@Ethanlm
Copy link
Contributor

Ethanlm commented Oct 10, 2019

We need this plus other CLI fixes in 2.1.x-branch too.

kishorvpatil
kishorvpatil approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@kishorvpatil kishorvpatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@govind-menon govind-menon merged commit 8bbd15b into apache:master Oct 11, 2019
@govind-menon govind-menon deleted the STORM-3520 branch October 11, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishorvpatil kishorvpatil kishorvpatil approved these changes

@Ethanlm Ethanlm Ethanlm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@govind-menon @Ethanlm @kishorvpatil