Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move OPC-UA processor and sink into a single module #1648

Closed
dominikriemer opened this issue Jun 2, 2023 · 3 comments · Fixed by #1649
Closed

Move OPC-UA processor and sink into a single module #1648

dominikriemer opened this issue Jun 2, 2023 · 3 comments · Fixed by #1649
Assignees
@dominikriemer
Labels
connect Related to the `connect` module (adapters) refactoring Indicates when a pull request or issue contains larger refactoring aspects.
Milestone
0.93.0

Comments

@dominikriemer
Copy link
Member

Body

Merge the OPC-UA processor and the OPC-UA data sink into a new module streampipes-connectors-opcua to facilitate code reuse.

StreamPipes Committer

I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.
@dominikriemer dominikriemer added this to the 0.93.0 milestone Jun 2, 2023
@dominikriemer dominikriemer self-assigned this Jun 2, 2023
dominikriemer added a commit that referenced this issue Jun 2, 2023
@dominikriemer
Move OPC-UA processor and sinks to new module streampipes-connectors-…
9b8bfb8 
…opcua (#1648)
@dominikriemer dominikriemer linked a pull request Jun 2, 2023 that will close this issue
Move OPC-UA processor and sinks to new module streampipes-connectors-… #1649
Merged
@dominikriemer dominikriemer mentioned this issue Jun 2, 2023
Merged
@bossenti
Copy link
Contributor

bossenti commented Jun 2, 2023

great @dominikriemer!
I've added this task directly in my OPC UA action plan: #1650

Should we include the description in the README mentioned there also in this issue or would you rather like to have a dedicated one?

@bossenti bossenti added refactoring Indicates when a pull request or issue contains larger refactoring aspects. connect Related to the `connect` module (adapters) labels Jun 2, 2023
@dominikriemer
Copy link
Member Author

Should we create the README once we've refactored the adapter to share settings between the adapter and sink? I guess some configs might change until then...

@bossenti
Copy link
Contributor

bossenti commented Jun 2, 2023

Sounds good 👍

dominikriemer added a commit that referenced this issue Jun 6, 2023
@dominikriemer
Move OPC-UA processor and sinks to new module streampipes-connectors-…
76afaef 
…opcua (#1648) (#1649)
jjbiggins pushed a commit to jjbiggins/streampipes that referenced this issue Jul 5, 2023
@dominikriemer @jjbiggins
Move OPC-UA processor and sinks to new module streampipes-connectors-…
0283905 
…opcua (apache#1648) (apache#1649)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominikriemer dominikriemer

Labels
connect Related to the `connect` module (adapters) refactoring Indicates when a pull request or issue contains larger refactoring aspects.
Projects
None yet
Milestone
0.93.0
Development

Successfully merging a pull request may close this issue.

Move OPC-UA processor and sinks to new module streampipes-connectors-… apache/streampipes
2 participants
@dominikriemer @bossenti