Apply UI linting to all modules #877

bossenti · 2022-12-21T18:10:54Z

Body

The following modules need to be included into the UI linting:

Please update ui/.eslintignore and ui/.prettierignore if a module is updated.
Furthermore check to corresponding module in the list above and paste a link to the PR (see #820).

Mentoring

As this ticket is marked as good first issue: one of @dominikriemer, @tenthe, @smlabt or @bossenti is happy to provide help for getting started, just tag (one of) them if you want to start working on this issue and need some help.

StreamPipes Committer

I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.

The text was updated successfully, but these errors were encountered:

aamirxshaikh · 2022-12-21T18:40:03Z

Hey, I'm new to contributing to open source and I'm interested in contributing to this issue. How can I get started with it?
@dominikriemer @tenthe @smlabt @bossenti

bossenti · 2022-12-22T06:51:52Z

Hi @aamirshaikh7,
welcome to StreamPipes, great to hear that you want to contribute 🎉

This issue depends on #876 and therefore it's preferable to have this PR merged before starting to work on this issue.
I expect this to happen in the upcoming days.

Nevertheless, I'll give a quick wrap up what to do:

Choose one of the UI models listed above and remove them from ui/.eslintignore and ui/.prettierignore locally
Run the UI commit hook like described in the README
Fix the detected issues automatically (see README) or by hand
create a PR with your changes

In case you already want to contribute, feel free to have a look on our other issues.
There are some more good first issues.
If you are interested in UI development, you could for example have a look in #793

aamirxshaikh · 2022-12-23T10:12:14Z

Hi, @bossenti

I have few questions.

Do all models mentioned above needs to be removed from ui/.eslintignore and ui/.prettierignore?

Regarding the README, It is mentioned that "node and npm (bundled with node) installed.", meaning both Node and npm need to be installed? I have installed Node and npm via nvm. Will this work?

Thankyou.

bossenti · 2022-12-23T11:11:44Z

Do all models mentioned above needs to be removed from ui/.eslintignore and ui/.prettierignore?

Not at once but in the end, yes. The idea is to remove them step by step. So in best case you only remove one module from both files, run the tools and check where things need to adapted.
You can provide one PR per module or group more modules in one but please ensure that PRs don't get to big.

Regarding the README, It is mentioned that "node and npm (bundled with node) installed.", meaning both Node and npm need to be installed? I have installed Node and npm via nvm. Will this work?

Shouldn't be a problem, afaik

aamirxshaikh · 2022-12-23T15:14:51Z

I have removed Cypress model from .eslintignore and .prettierignore.

I'm using Node v19.3.0 and npm version 9.2.0

npm install --legacy-peer-deps

npm WARN deprecated source-map-url@0.4.1: See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated chokidar@2.1.8: Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
npm WARN deprecated source-map-resolve@0.5.3: See https://github.com/lydell/source-map-resolve#deprecated    
npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead
npm WARN deprecated querystring@0.2.0: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
npm WARN deprecated source-map-resolve@0.6.0: See https://github.com/lydell/source-map-resolve#deprecated    
npm WARN deprecated mumath@3.3.4: Redundant dependency in your project.
npm WARN deprecated @npmcli/move-file@2.0.1: This functionality has been moved to @npmcli/fs
npm WARN deprecated @angular/flex-layout@14.0.0-beta.41: This package has been deprecated. Please see https://blog.angular.io/modern-css-in-angular-layouts-4a259dca9127

> apache-streampipes@0.91.0-SNAPSHOT prepare
> cd ../ && husky install ./ui/.husky

husky - Git hooks installed

added 2289 packages, and audited 2290 packages in 7m

258 packages are looking for funding
  run `npm fund` for details

14 vulnerabilities (1 moderate, 13 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.

npm run build

> apache-streampipes@0.91.0-SNAPSHOT build
> node ./deployment/prebuild.js && set NODE_OPTIONS=--max-old-space-size=8192 && npm run build-libraries && ng build --configuration production

Pre-Build started.
No build config specified. Using default config for dev.
Active Angular Module: spPipelines
Active Angular Module: spConnect
Active Angular Module: spDashboard
Active Angular Module: spDataExplorer
Active Angular Module: spAppOverview
Active Angular Module: spAdd
Active Angular Module: spAssets
Active Angular Module: spFiles
Active Angular Module: spConfiguration
Moved: logo.png
Moved: sp-logo-navigation.png
Moved: favicon
Moved: theme file
Moved: webpack dev config
Pre-Build finished.

> apache-streampipes@0.91.0-SNAPSHOT build-libraries
> npm run build-libs && npm run install-libs


> apache-streampipes@0.91.0-SNAPSHOT build-libs
> ng build @streampipes/platform-services && ng build @streampipes/shared-ui

Node.js version v19.3.0 detected.
Odd numbered Node.js versions will not enter LTS status and should not be used for production. For more information, please see https://nodejs.org/en/about/releases/.
Building Angular Package

------------------------------------------------------------------------------
Building entry point '@streampipes/platform-services'
------------------------------------------------------------------------------
✔ Compiling with Angular sources in Ivy partial compilation mode.
✔ Generating FESM2020
✔ Generating FESM2015
✔ Copying assets
ℹ Removing devDependencies section in package.json.
✔ Writing package manifest
✔ Built @streampipes/platform-services

------------------------------------------------------------------------------
Built Angular Package
 - from: D:\root\Code\Open source\streampipes\ui\projects\streampipes\platform-services
 - to:   D:\root\Code\Open source\streampipes\ui\dist\streampipes\platform-services
------------------------------------------------------------------------------

Build at: 2022-12-23T14:17:14.951Z - Time: 14062ms

Node.js version v19.3.0 detected.
Odd numbered Node.js versions will not enter LTS status and should not be used for production. For more information, please see https://nodejs.org/en/about/releases/.
Building Angular Package

------------------------------------------------------------------------------
Building entry point '@streampipes/shared-ui'
------------------------------------------------------------------------------
✔ Compiling with Angular sources in Ivy partial compilation mode.
✔ Generating FESM2020
✔ Generating FESM2015
✔ Copying assets
✔ Writing package manifest
✔ Built @streampipes/shared-ui

------------------------------------------------------------------------------
Built Angular Package
 - from: D:\root\Code\Open source\streampipes\ui\projects\streampipes\shared-ui
 - to:   D:\root\Code\Open source\streampipes\ui\dist\streampipes\shared-ui
------------------------------------------------------------------------------

Build at: 2022-12-23T14:17:22.767Z - Time: 5848ms


> apache-streampipes@0.91.0-SNAPSHOT install-libs
> npm install @streampipes/platform-services@file:./dist/streampipes/platform-services @streampipes/shared-ui@file:./dist/streampipes/shared-ui --no-save

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: rxjs-for-await@0.0.2
npm WARN Found: rxjs@7.8.0
npm WARN node_modules/rxjs
npm WARN   peer rxjs@">=6.6.3" from @angular-architects/module-federation@14.3.14
npm WARN   node_modules/@angular-architects/module-federation
npm WARN     @angular-architects/module-federation@"^14.3.14" from the root project
npm WARN   18 more (@angular/cdk, @angular/common, @angular/core, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer rxjs@"^6.0.0" from rxjs-for-await@0.0.2
npm WARN node_modules/rxjs-for-await
npm WARN   rxjs-for-await@"0.0.2" from @nrwl/tao@13.1.3
npm WARN   node_modules/@nrwl/tao
npm WARN
npm WARN Conflicting peer dependency: rxjs@6.6.7
npm WARN node_modules/rxjs
npm WARN   peer rxjs@"^6.0.0" from rxjs-for-await@0.0.2
npm WARN   node_modules/rxjs-for-await
npm WARN     rxjs-for-await@"0.0.2" from @nrwl/tao@13.1.3
npm WARN     node_modules/@nrwl/tao

added 2 packages, removed 1 package, and audited 2292 packages in 14s

258 packages are looking for funding
  run `npm fund` for details

15 vulnerabilities (2 moderate, 13 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.
Node.js version v19.3.0 detected.
Odd numbered Node.js versions will not enter LTS status and should not be used for production. For more information, please see https://nodejs.org/en/about/releases/.
⠙ Generating browser application bundles (phase: setup)...Processing legacy "View Engine" libraries:
- @ngx-loading-bar/core [es2015/esm2015] (https://github.com/aitboudad/ngx-loading-bar.git)
- @auth0/angular-jwt [es2015/esm2015] (git+https://github.com/auth0/angular2-jwt)
- angular-plotly.js [es2015/esm2015] ()
- ngx-color-picker [es2015/esm2015] ()
- ngx-showdown [es2015/esm2015] (https://github.com/yisraelx/ngx-showdown.git)
- @circlon/angular-tree-component [es2015/esm2015] (https://github.com/CirclonGroup/angular-tree-component.git)
- @asymmetrik/ngx-leaflet [module/esm5] (https://github.com/Asymmetrik/ngx-leaflet.git)
- @ngx-loading-bar/http-client [es2015/esm2015] (https://github.com/aitboudad/ngx-loading-bar.git)
Encourage the library authors to publish an Ivy distribution.
✔ Browser application bundle generation complete.
✔ Copying assets complete.
✔ Index html generation complete.

Initial Chunk Files           | Names         |  Raw Size | Estimated Transfer Size
main.4de047acc166de96.js      | main          |   7.13 MB |                 1.39 MB
scripts.c43a350a022f7435.js   | scripts       |   4.13 MB |                 1.01 MB
polyfills.8c9bd5b96c65f0c3.js | polyfills     |   1.56 MB |               304.64 kB
styles.f37f3afe7ea647ab.css   | styles        | 500.39 kB |                56.69 kB
runtime.ce57a00b859f65f6.js   | runtime       |  18.28 kB |                 4.27 kB

                              | Initial Total |  13.33 MB |                 2.76 MB

Lazy Chunk Files              | Names         |  Raw Size | Estimated Transfer Size
918.23e0dc1248177c8f.js       | echarts       | 628.87 kB |               166.30 kB
971.db6f19931fcef8ad.js       | quill         | 209.60 kB |                42.15 kB

Build at: 2022-12-23T14:20:40.919Z - Hash: b8f17da653c3c71a - Time: 169766ms

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\@asymmetrik\ngx-leaflet\__ivy_ngcc__\dist\leaflet\core\leaflet.directive.js depends on 'leaflet'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\@swimlane\ngx-charts\fesm2020\swimlane-ngx-charts.mjs depends on 'rfdc'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\ngx-quill\fesm2020\ngx-quill.mjs depends on 'quill'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\ngx-showdown\__ivy_ngcc__\fesm2015\ngx-showdown.js depends on 'showdown'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\react-redux\es\components\connectAdvanced.js depends on 'hoist-non-react-statics'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\swagger-client\es\specmap\helpers.js depends on 'traverse'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\swagger-ui\dist\swagger-ui-es-bundle-core.js depends on '@babel/runtime-corejs3/regenerator'. CommonJS or AMD dependencies can cause optimization bailouts. 
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\swagger-ui\dist\swagger-ui-es-bundle-core.js depends on '@braintree/sanitize-url'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\swagger-ui\dist\swagger-ui-es-bundle-core.js depends on 'base64-js'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\swagger-ui\dist\swagger-ui-es-bundle-core.js depends on 'classnames'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\swagger-ui\dist\swagger-ui-es-bundle-core.js depends on 'css.escape'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\swagger-ui\dist\swagger-ui-es-bundle-core.js depends on 'dompurify'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\swagger-ui\dist\swagger-ui-es-bundle-core.js depends on 'ieee754'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\swagger-ui\dist\swagger-ui-es-bundle-core.js depends on 'immutable'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\swagger-ui\dist\swagger-ui-es-bundle-core.js depends on 'js-file-download'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\swagger-ui\dist\swagger-ui-es-bundle-core.js depends on 'prop-types'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\swagger-ui\dist\swagger-ui-es-bundle-core.js depends on 'randexp'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\swagger-ui\dist\swagger-ui-es-bundle-core.js depends on 'react-copy-to-clipboard'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\swagger-ui\dist\swagger-ui-es-bundle-core.js depends on 'react-debounce-input'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\swagger-ui\dist\swagger-ui-es-bundle-core.js depends on 'react-immutable-proptypes'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\swagger-ui\dist\swagger-ui-es-bundle-core.js depends on 'redux-immutable'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\swagger-ui\dist\swagger-ui-es-bundle-core.js depends on 'serialize-error'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\swagger-ui\dist\swagger-ui-es-bundle-core.js depends on 'url-parse'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\swagger-ui\dist\swagger-ui-es-bundle-core.js depends on 'xml-but-prettier'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\node_modules\swagger-ui\dist\swagger-ui-es-bundle-core.js depends on 'zenscroll'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\src\app\connect\components\adapter-configuration\schema-editor\event-schema\event-schema.component.ts depends on 'angular2-uuid'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\src\app\core-ui\image\services\BrushLabeling.service.ts depends on 'konva'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\src\app\core-ui\static-properties\static-code-input\static-code-input.component.ts depends on 'jshint'. CommonJS or AMD dependencies can cause optimization bailouts.    
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\src\app\editor\services\pipeline-positioning.service.ts depends on 'dagre'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: D:\root\Code\Open source\streampipes\ui\src\app\pipelines\pipelines.component.ts depends on 'file-saver'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: ▲ [WARNING] Expected identifier but found "*" [css-syntax-error]

    styles.cb03237a769a8a20.css:6059:16:
      6059 │ .swagger-ui .cf{*zoom:1}
           ╵                 ^



Warning: ▲ [WARNING] Expected identifier but found "*" [css-syntax-error]

    styles.cb03237a769a8a20.css:7864:2:
      7864 │   *zoom: 1;
           ╵   ^



Warning: ▲ [WARNING] Expected identifier but found "*" [css-syntax-error]

    styles.cb03237a769a8a20.css:7908:2:
      7908 │   *display: inline;
           ╵   ^



Warning: ▲ [WARNING] Expected identifier but found "*" [css-syntax-error]

    styles.cb03237a769a8a20.css:7910:2:
      7910 │   *vertical-align: auto;
           ╵   ^



Warning: ▲ [WARNING] Expected identifier but found "*" [css-syntax-error]

    styles.cb03237a769a8a20.css:7911:2:
      7911 │   *zoom: 1;
           ╵   ^



Warning: ▲ [WARNING] Expected identifier but found "*" [css-syntax-error]

    styles.cb03237a769a8a20.css:8053:2:
      8053 │   *zoom: 1;
           ╵   ^



Warning: ▲ [WARNING] Expected identifier but found "*" [css-syntax-error]

    styles.cb03237a769a8a20.css:8150:2:
      8150 │   *display: inline;
           ╵   ^



Warning: ▲ [WARNING] Expected identifier but found "*" [css-syntax-error]

    styles.cb03237a769a8a20.css:8152:2:
      8152 │   *vertical-align: auto;
           ╵   ^



Warning: ▲ [WARNING] Expected identifier but found "*" [css-syntax-error]

    styles.cb03237a769a8a20.css:8153:2:
      8153 │   *zoom: 1;
           ╵   ^



Warning: ▲ [WARNING] Expected identifier but found "*" [css-syntax-error]

    styles.cb03237a769a8a20.css:14008:2:
      14008 │   *border-right-width: 2px;
            ╵   ^



Warning: ▲ [WARNING] Expected identifier but found "*" [css-syntax-error]

    styles.cb03237a769a8a20.css:14009:2:
      14009 │   *border-bottom-width: 2px;
            ╵   ^

I can see getting few warning messages while building the project, haven't come across any errors.

bossenti · 2022-12-23T17:16:55Z

@smlabt can you help out here?
Frankly, I'm not really an UI expert 🤠

smlabt · 2022-12-23T18:49:33Z

@bossenti yes, sure :) @aamirshaikh7 you have to use npm run format and npm run lint now to get the respective errors and warnings.

aamirxshaikh · 2022-12-23T20:41:19Z

I encountered error while running npm run format. So, I followed the README and I ran npm run format:fix

After that both run format and run lint passed.

npm run format

> apache-streampipes@0.91.0-SNAPSHOT format
> prettier --check .

Checking formatting...
All matched files use Prettier code style!

npm run lint

> apache-streampipes@0.91.0-SNAPSHOT lint
> ng lint

Node.js version v19.3.0 detected.
Odd numbered Node.js versions will not enter LTS status and should not be used for production. For more information, please see https://nodejs.org/en/about/releases/.        

Linting "app"...

All files pass linting.

@bossenti @smlabt If you're satisfied with these results. Can I make PR for this module (Cypress) ? You can review it.

smlabt · 2022-12-23T20:46:16Z

@aamirshaikh7 great, sounds good! Yes, please open a PR for this module.

aamirxshaikh · 2022-12-23T22:08:15Z

@smlabt On committing the changes, I'm getting an error.

error: cannot spawn ui/.husky/pre-commit: No such file or directory

smlabt · 2022-12-23T22:34:05Z

Unfortunately I do not have a windows machine to reproduce and debug this issue right now. Are you running git commit from the ui directory? Then please try to run it from the project root.

If this is not working for you, you can run git commit with the --no-verify flag. This will skip the pre-commit hook. I will than have a look into this later.

aamirxshaikh · 2022-12-24T07:02:05Z

I'm running git commit from project root only, but still getting the same error.

I have used git commit with --no-verify. It worked.

aamirxshaikh · 2022-12-25T09:34:09Z

Can I make PR for this module? @smlabt You can review it.

smlabt · 2022-12-25T10:13:55Z

Yes, please open a PR for your changes :)

[#877] Format and lint core-ui module

* [#877] apply formatting and linting to files module * [#877] remove dead code

…rial [#877] Format and lint CustomMaterial module

* [#877] apply formatting and linting to data-explorer module * [#877] remove reluctant onDestroy * [#877] implement onOptionsChanged Co-authored-by: Philipp Zehnder <tenthe@users.noreply.github.com>

* [#877] Format and lint dashboard module * [#877] Optimize imports for dashboard module Co-authored-by: Tim <50115603+bossenti@users.noreply.github.com>

* [#877] apply formatting and linting to editor module * [#877] adapt to refactoring Co-authored-by: Philipp Zehnder <tenthe@users.noreply.github.com>

bossenti · 2023-01-25T18:20:49Z

We have completed the linting and formatting for our UI 🎉
Thanks a lot for everyone involved @aamirxshaikh @tenthe @smlabt @dominikriemer
Great team effort 🤩

bossenti added help wanted Extra attention is needed good first issue Good for newcomers ui Anything that affects the UI labels Dec 21, 2022

bossenti added this to the 1.0.0 milestone Dec 21, 2022

bossenti mentioned this issue Dec 21, 2022

Add ci job for formatting and linting #876

Merged

aamirxshaikh added a commit to aamirxshaikh/streampipes that referenced this issue Dec 24, 2022

[apache#877] Apply UI linting to cypress module

289d269

bossenti pushed a commit that referenced this issue Dec 27, 2022

[#877] Apply UI linting to cypress module (#891)

ef039e5

bossenti pushed a commit that referenced this issue Dec 29, 2022

style: [#877] format and lint deployment directory (#920)

2e167f7

aamirxshaikh added a commit to aamirxshaikh/streampipes that referenced this issue Jan 2, 2023

[apache#877] Apply UI linting to projects module

959fc3a

aamirxshaikh added a commit to aamirxshaikh/streampipes that referenced this issue Jan 2, 2023

[apache#877] Fix params

6c8425a

bossenti added a commit that referenced this issue Jan 2, 2023

add linting to enums module (#877)

3760347

bossenti added a commit that referenced this issue Jan 2, 2023

add linting to enums guards (#877)

c2e0811

bossenti added a commit that referenced this issue Jan 2, 2023

add linting to enums models (#877)

5f109cb

bossenti added a commit that referenced this issue Jan 2, 2023

add linting to guards model (#877)

938fb55

bossenti added a commit that referenced this issue Jan 2, 2023

add linting to models module (#877)

edd7d26

bossenti mentioned this issue Jan 2, 2023

chore: add linting to UI modules enums, guards, models #1020

Merged

tenthe added a commit that referenced this issue Jan 21, 2023

Merge pull request #1120 from aamirxshaikh/STREAMPIPES-877-core-ui

371a297

[#877] Format and lint core-ui module

bossenti added a commit that referenced this issue Jan 21, 2023

[#877] apply formatting and linting to login module (#1134)

4db9325

bossenti added a commit that referenced this issue Jan 21, 2023

[#877] apply formatting and linting to files module

0672101

bossenti added a commit that referenced this issue Jan 21, 2023

[#877] remove dead code

81ac3dd

bossenti added a commit that referenced this issue Jan 21, 2023

[#877] apply formatting and linting to info module (#1136)

cd26f1f

bossenti added a commit that referenced this issue Jan 21, 2023

[#877] apply formatting and linting to files module

a8d53d4

bossenti added a commit that referenced this issue Jan 21, 2023

[#877] remove dead code

486849f

bossenti added a commit that referenced this issue Jan 21, 2023

[#877] remove reluctant onDestroy

075114e

bossenti added a commit that referenced this issue Jan 21, 2023

[#877] apply formatting and linting to editor module

f5165aa

bossenti added a commit that referenced this issue Jan 22, 2023

[#877] apply formatting and linting to files module (#1137)

4655a9a

* [#877] apply formatting and linting to files module * [#877] remove dead code

aamirxshaikh added a commit to aamirxshaikh/streampipes that referenced this issue Jan 22, 2023

[apache#877] Format and lint CustomMaterial module

407f1dc

bossenti added a commit that referenced this issue Jan 23, 2023

[#877] apply formatting and linting to data-explorer module

73b7296

bossenti added a commit that referenced this issue Jan 23, 2023

[#877] remove reluctant onDestroy

11bda34

bossenti added a commit that referenced this issue Jan 23, 2023

[#877] implement onOptionsChanged

861f44a

bossenti added a commit that referenced this issue Jan 23, 2023

[#877] apply formatting and linting to editor module

52523ab

bossenti added a commit that referenced this issue Jan 23, 2023

[#877] adapt to refactoring

f68fb5c

tenthe added a commit that referenced this issue Jan 24, 2023

Merge pull request #1144 from aamirxshaikh/STREAMPIPES-877-CustomMate…

6a5b00d

…rial [#877] Format and lint CustomMaterial module

aamirxshaikh added a commit to aamirxshaikh/streampipes that referenced this issue Jan 24, 2023

[apache#877] Format and lint dashboard module

9252825

aamirxshaikh added a commit to aamirxshaikh/streampipes that referenced this issue Jan 24, 2023

[apache#877] Optimize imports for dashboard module

0870f1e

bossenti added a commit that referenced this issue Jan 25, 2023

[#877] Format and lint dashboard module (#1154)

b89ab89

* [#877] Format and lint dashboard module * [#877] Optimize imports for dashboard module Co-authored-by: Tim <50115603+bossenti@users.noreply.github.com>

bossenti added a commit that referenced this issue Jan 25, 2023

[#877] apply formatting and linting to editor module (#1138)

f38b079

* [#877] apply formatting and linting to editor module * [#877] adapt to refactoring Co-authored-by: Philipp Zehnder <tenthe@users.noreply.github.com>

bossenti closed this as completed Jan 25, 2023

bossenti modified the milestones: 1.0.0, 0.91.0 Jan 30, 2023

bossenti assigned tenthe, smlabt, bossenti and aamirxshaikh Feb 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Apply UI linting to all modules #877

Apply UI linting to all modules #877

bossenti commented Dec 21, 2022 •

edited

aamirxshaikh commented Dec 21, 2022 •

edited

bossenti commented Dec 22, 2022

aamirxshaikh commented Dec 23, 2022

bossenti commented Dec 23, 2022

aamirxshaikh commented Dec 23, 2022

bossenti commented Dec 23, 2022 •

edited

smlabt commented Dec 23, 2022

aamirxshaikh commented Dec 23, 2022

smlabt commented Dec 23, 2022

aamirxshaikh commented Dec 23, 2022

smlabt commented Dec 23, 2022

aamirxshaikh commented Dec 24, 2022

aamirxshaikh commented Dec 25, 2022

smlabt commented Dec 25, 2022

bossenti commented Jan 25, 2023

Apply UI linting to all modules #877

Apply UI linting to all modules #877

Comments

bossenti commented Dec 21, 2022 • edited

Body

Mentoring

StreamPipes Committer

aamirxshaikh commented Dec 21, 2022 • edited

bossenti commented Dec 22, 2022

aamirxshaikh commented Dec 23, 2022

bossenti commented Dec 23, 2022

aamirxshaikh commented Dec 23, 2022

bossenti commented Dec 23, 2022 • edited

smlabt commented Dec 23, 2022

aamirxshaikh commented Dec 23, 2022

smlabt commented Dec 23, 2022

aamirxshaikh commented Dec 23, 2022

smlabt commented Dec 23, 2022

aamirxshaikh commented Dec 24, 2022

aamirxshaikh commented Dec 25, 2022

smlabt commented Dec 25, 2022

bossenti commented Jan 25, 2023

bossenti commented Dec 21, 2022 •

edited

aamirxshaikh commented Dec 21, 2022 •

edited

bossenti commented Dec 23, 2022 •

edited