feature: retrieve credentials from SP environment variables #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
bossenti
added
deprecation
dominikriemer
approved these changes
May 30, 2023
github-actions
bot
added
dependencies
SvenO3
approved these changes
May 31, 2023
Signed-off-by: bossenti <bossenti@posteo.de>
Signed-off-by: bossenti <bossenti@posteo.de>
bossenti
force-pushed
the
feature/retrieve-crendetials-from-envs
branch
from
c8a03b6
to
0276125
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR allows to retrieve credentials for the Python client directly from the environment variables without the need to call an additional method (previously:
from_env()).The credential chain applied here looks the following:
StreamPipesApiKeyCredentials()if not passed:
SP_API_KEYandSP_USERNAMEare checked.Remarks
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): yes