-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove legacy demo resources #2066
Conversation
follow-up task: #2067 |
@bossenti if I'm not mistaken the PR not only removes the demo sources, but also the |
@dominikriemer Good point! I deleted
Both only have been used by the two demo sources removed within this PR so I considered them to be legacy 😅 So are they still required to create a data stream? If my understanding is correct, a StreamPipes Function uses the the client to generate a new data stream, for example. |
Yes, I think they are not directly needed by the function but users can use these convenience classes to create data streams in the SDK. These are the classes we currently mention in the data stream tutorial (https://streampipes.apache.org/docs/extend-tutorial-data-sources/). |
Okay, then let's keep them. |
@bossenti can it be moved to streampipes-extensions-management? Since they are helper classes similar to the PullAdapter. |
# Conflicts: # streampipes-extensions/pom.xml
Purpose
This PR removes some legacy resources that have been used for demo purposes but are rather outdated.
Remarks
PR introduces (a) breaking change(s): yes (see below)
PR introduces (a) deprecation(s): no
Breaking Change
This PR removes two data sources from StreamPipes:
watertank-simulator
vehicle-simulator